[jira] [Comment Edited] (HBASE-11393) Replication TableCfs should be a PB object rather than a string

["Heng Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013323#comment-15013323 ] 

Heng Chen edited comment on HBASE-11393 at 11/19/15 11:01 AM:
--------------------------------------------------------------

Update a new patch. 
changes:
 *  Modify some code as [~enis] suggestions in review board.
 *  support namespace as [~ashishujjain] suggestions.

Review board update too.

btw.
There are some similar code in  ReplicationPeers,  i am not sure the context of these methods, could unify them? 
{code: title=ReplicationPeers.java}
   * Add a new remote slave cluster for replication.
   * @param peerId a short that identifies the cluster
   * @param peerConfig configuration for the replication slave cluster
   */
  void addPeer(String peerId, ReplicationPeerConfig peerConfig)
      throws ReplicationException;

  /**
   * Removes a remote slave cluster and stops the replication to it.
   * @param peerId a short that identifies the cluster
   */
  void removePeer(String peerId) throws ReplicationException;

  boolean peerAdded(String peerId) throws ReplicationException;

  @Deprecated
  void peerRemoved(String peerId);
{code}






was (Author: chenheng):
Update a new patch. 
changes:
 *  Modify some code as @enis suggestions in review board.
 *  support namespace as [~ashishujjain] suggestions.

Review board update too.


> Replication TableCfs should be a PB object rather than a string
> ---------------------------------------------------------------
>
>                 Key: HBASE-11393
>                 URL: https://issues.apache.org/jira/browse/HBASE-11393
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11393.patch, HBASE-11393_v1.patch, HBASE-11393_v10.patch, HBASE-11393_v2.patch, HBASE-11393_v3.patch, HBASE-11393_v4.patch, HBASE-11393_v5.patch, HBASE-11393_v6.patch, HBASE-11393_v7.patch, HBASE-11393_v8.patch, HBASE-11393_v9.patch
>
>
> We concatenate the list of tables and column families in format  "table1:cf1,cf2;table2:cfA,cfB" in zookeeper for table-cf to replication peer mapping. 
> This results in ugly parsing code. We should do this a PB object. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)