You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/12/11 21:09:32 UTC
[PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
adoroszlai opened a new pull request, #5776:
URL: https://github.com/apache/ozone/pull/5776
## What changes were proposed in this pull request?
HDDS-8095 copied the `StreamCapabilities` interface from Hadoop, added by HDFS-11644 in 2.9. Since we have upgraded to Hadoop 2.10, it is no longer needed.
https://issues.apache.org/jira/browse/HDDS-8113
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7172435971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #5776:
URL: https://github.com/apache/ozone/pull/5776#issuecomment-1858203989
What about CapableOzoneFSInputStream and CapableOzoneFSInputStream? IIRC they were also added to workaround the lack of StreamCapabilities in Hadoop 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5776:
URL: https://github.com/apache/ozone/pull/5776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5776:
URL: https://github.com/apache/ozone/pull/5776#issuecomment-1858355012
> What about CapableOzoneFSInputStream and CapableOzoneFSInputStream? IIRC they were also added to workaround the lack of StreamCapabilities in Hadoop 2.
Yes, they implement `StreamCapabilities` as subclasses, separate from the base `OzoneFS*Stream` classes due to compatibility. But their code is not copied from Hadoop, so we need to put it somewhere. I don't see much benefit in merging them into their base classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5776:
URL: https://github.com/apache/ozone/pull/5776#issuecomment-1858084387
/ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5776:
URL: https://github.com/apache/ozone/pull/5776#issuecomment-1852687454
/pending let's wait with this until branch cut, so that 1.4.0 can still support Hadoop 2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8113. Remove Hadoop 2.7 compatibility hack [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5776:
URL: https://github.com/apache/ozone/pull/5776#issuecomment-1868568428
Thanks @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org