You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Adebski <gi...@git.apache.org> on 2017/07/08 15:05:18 UTC
[GitHub] flink pull request #4290: [FLINK-7133]Excluding optional asm dependencies fr...
GitHub user Adebski opened a pull request:
https://github.com/apache/flink/pull/4290
[FLINK-7133]Excluding optional asm dependencies from elasticsearch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Adebski/flink flink-7133-excluding-asm-from-elastic-search-base
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4290
----
commit c26f15f8ee10f38b16aa8eb78581980f6359df95
Author: adebski <an...@gmail.com>
Date: 2017-07-08T15:03:18Z
[FLINK-7133]Excluding optional asm dependencies from elasticsearch artifact so they don't conflict with other shaded asm releases.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4290: [FLINK-7133]Excluding optional asm dependencies fr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4290: [FLINK-7133]Excluding optional asm dependencies from elas...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4290
Thanks for the PR @Adebski!
Given that this was tested already for both local and cluster execution,+1 from me once Travis is green.
Could you also include a comment, preferably referencing the JIRA, on why the dependency is excluded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4290: [FLINK-7133]Excluding optional asm dependencies from elas...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4290
yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4290: [FLINK-7133]Excluding optional asm dependencies from elas...
Posted by Adebski <gi...@git.apache.org>.
Github user Adebski commented on the issue:
https://github.com/apache/flink/pull/4290
You mean in the pom.xml itself yes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4290: [FLINK-7133]Excluding optional asm dependencies from elas...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4290
Thanks for fixing this @Adebski. 👍 I merged, could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---