[GitHub] [airflow] hussein-awala commented on a diff in pull request #33438: Allowing ability to add custom env into pgbouncer container

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on code in PR #33438:
URL: https://github.com/apache/airflow/pull/33438#discussion_r1296024486


##########
chart/templates/pgbouncer/pgbouncer-deployment.yaml:
##########
@@ -101,6 +101,13 @@ spec:
           args: {{ tpl (toYaml .Values.pgbouncer.args) . | nindent 12 }}
           {{- end }}
           resources: {{- toYaml .Values.pgbouncer.resources | nindent 12 }}
+          {{- if .Values.pgbouncer.env }}
+          env:
+            {{- range $i, $config := .Values.pgbouncer.env }}
+            - value: {{ $config.value }}
+              name: {{ $config.name }}
+            {{- end }}
+          {{- end }}

Review Comment:
   Could we add the value as it is instead of looping over the values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org