You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/02/08 13:30:58 UTC

[GitHub] [hudi] cxzl25 opened a new pull request, #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

cxzl25 opened a new pull request, #7898:
URL: https://github.com/apache/hudi/pull/7898

   ### Change Logs
   
   Add guava dependency to Spark and MR bundle
   
   ### Impact
   
   Configure guava relocation in Spark and MR bundle pom.xml, but there is no guava dependency, resulting in failure of guava-related class loading.
   
   [HUDI-4482] remove guava and use caffeine instead for cache (#6240)
   
   ### Risk level (write none, low medium or high below)
   
   
   ### Documentation Update
   
   
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1423255409

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e10025521ff7a24978b9f22b1180bce55e2238fe",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15040",
       "triggerID" : "e10025521ff7a24978b9f22b1180bce55e2238fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e10025521ff7a24978b9f22b1180bce55e2238fe Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15040) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1422667273

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e10025521ff7a24978b9f22b1180bce55e2238fe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e10025521ff7a24978b9f22b1180bce55e2238fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e10025521ff7a24978b9f22b1180bce55e2238fe UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1423397463

   #7900 is addressing this properly by removing unnecessary relocations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] cxzl25 commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1422609389

   @pan3793 first found this problem.
   
   cc  @KnightChess @xushiyan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1423117320

   After some discussions we agreed on following
    - This PR will be landed to unblock 0.13
    - On master we revert back to remove guava as well as any excessive shading of `com.google.common` classes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1422678191

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e10025521ff7a24978b9f22b1180bce55e2238fe",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15040",
       "triggerID" : "e10025521ff7a24978b9f22b1180bce55e2238fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e10025521ff7a24978b9f22b1180bce55e2238fe Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15040) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1440443878

   @bvaradar yes, we can close this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar commented on pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #7898:
URL: https://github.com/apache/hudi/pull/7898#issuecomment-1439677259

   @yihua @alexeykudinkin : Should this be closed since https://github.com/apache/hudi/pull/7900 is landed ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin closed pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle

Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin closed pull request #7898: [HUDI-5731] Add guava dependency to Spark and MR bundle
URL: https://github.com/apache/hudi/pull/7898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org