You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Darrel Schneider (JIRA)" <ji...@apache.org> on 2015/06/30 20:34:04 UTC

[jira] [Created] (GEODE-71) javadocs for the reason IllegalArgumentException is thrown from addLocator, addServer, addPoolLocator, and addPoolServer are not correct

Darrel Schneider created GEODE-71:
-------------------------------------

             Summary: javadocs for the reason IllegalArgumentException is thrown from addLocator, addServer, addPoolLocator, and addPoolServer are not correct
                 Key: GEODE-71
                 URL: https://issues.apache.org/jira/browse/GEODE-71
             Project: Geode
          Issue Type: Bug
          Components: client/server
    Affects Versions: 1.0.0-incubating
            Reporter: Darrel Schneider
            Assignee: Darrel Schneider
            Priority: Trivial
             Fix For: 1.0.0-incubating


The reason why an IllegalArgumentException is thrown from ClientCacheFactory#addPoolLocator,ClientCacheFactory#addPoolServer,PoolFactory#addLocator, and PoolFactory#addServer is wrong.
The javadocs say:
if host is an unknown host according to InetAddress.getByName(String) or if port is outside the valid range of [1..65535] inclusive.
But they should say:
if port is outside the valid range of [0..65535] inclusive.

The product was changed in 7.0 to no longer throw an exception if the host is unknown. Instead it waits until the pool is used for an operation. Hopefully by that time the host will be know. If it still is not then an exception will be thrown.

Another part of this bug is that when the pool is created with an unknown host a fatal log message that just says "Hostname is unknown" is logged. Since this is not fatal the message should instead be a warning. The message should also explain that the pool will be created with the unknown host.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)