You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/02/10 22:10:45 UTC
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1497
Change subject: Encode queries with encodeURIComponent()
......................................................................
Encode queries with encodeURIComponent()
Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
---
M asterixdb/asterix-app/src/main/resources/queryui/js/main.js
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1497/1
diff --git a/asterixdb/asterix-app/src/main/resources/queryui/js/main.js b/asterixdb/asterix-app/src/main/resources/queryui/js/main.js
index 7a041f9..793c06e 100644
--- a/asterixdb/asterix-app/src/main/resources/queryui/js/main.js
+++ b/asterixdb/asterix-app/src/main/resources/queryui/js/main.js
@@ -128,7 +128,7 @@
}
$scope.initDataverses = function () {
- $http.get(SERVER_HOST + "/query?query=" + encodeURI(DATAVERSE_QUERY)).then(function (response) {
+ $http.get(SERVER_HOST + "/query?query=" + encodeURIComponent(DATAVERSE_QUERY)).then(function (response) {
for (i in response.data) {
$scope.dataverses.push(response.data[i].DataverseName);
$scope.selected_dataverse = $scope.dataverses[0];
@@ -147,8 +147,9 @@
$scope.query = function () {
var timer = new Date().getTime();
$scope.save($scope.query_input, $scope.selected_dataverse);
- $http.get(SERVER_HOST + "/query?query=" +
- encodeURI("use dataverse " + $scope.selected_dataverse + ";" + $scope.query_input))
+ var uri = SERVER_HOST + "/query?query=" +
+ encodeURIComponent("use dataverse " + $scope.selected_dataverse + ";" + $scope.query_input)
+ $http.get(uri)
.then(function (response) {
$scope.results = response.data;
console.log(response);
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Patch Set 1:
BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/515/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1856/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Encode queries with encodeURIComponent()
Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1497
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@apache.org>
---
M asterixdb/asterix-app/src/main/resources/queryui/js/main.js
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Ian Maxon: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
Objections:
Jenkins: Violations found
diff --git a/asterixdb/asterix-app/src/main/resources/queryui/js/main.js b/asterixdb/asterix-app/src/main/resources/queryui/js/main.js
index 7a041f9..793c06e 100644
--- a/asterixdb/asterix-app/src/main/resources/queryui/js/main.js
+++ b/asterixdb/asterix-app/src/main/resources/queryui/js/main.js
@@ -128,7 +128,7 @@
}
$scope.initDataverses = function () {
- $http.get(SERVER_HOST + "/query?query=" + encodeURI(DATAVERSE_QUERY)).then(function (response) {
+ $http.get(SERVER_HOST + "/query?query=" + encodeURIComponent(DATAVERSE_QUERY)).then(function (response) {
for (i in response.data) {
$scope.dataverses.push(response.data[i].DataverseName);
$scope.selected_dataverse = $scope.dataverses[0];
@@ -147,8 +147,9 @@
$scope.query = function () {
var timer = new Date().getTime();
$scope.save($scope.query_input, $scope.selected_dataverse);
- $http.get(SERVER_HOST + "/query?query=" +
- encodeURI("use dataverse " + $scope.selected_dataverse + ";" + $scope.query_input))
+ var uri = SERVER_HOST + "/query?query=" +
+ encodeURIComponent("use dataverse " + $scope.selected_dataverse + ";" + $scope.query_input)
+ $http.get(uri)
.then(function (response) {
$scope.results = response.data;
console.log(response);
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Patch Set 1: BAD-1
BAD Compatibility Tests Failed
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/515/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1856/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Encode queries with encodeURIComponent()
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Encode queries with encodeURIComponent()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4249/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No