[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7810: Remove Apache Pig from the tests

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #7810: Remove Apache Pig from the tests
URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r289620074
 
 

 ##########
 File path: extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/AvroFlattenerMaker.java
 ##########
 @@ -128,8 +126,8 @@ public Object getRootField(final GenericRecord record, final String key)
 
   private Object transformValue(final Object field)
   {
-    if (fromPigAvroStorage && field instanceof GenericData.Array) {
-      return Lists.transform((List) field, item -> String.valueOf(((GenericRecord) item).get(0)));
+    if (field instanceof GenericData.Array) {
 
 Review comment:
   Is this the right thing to do since the flag isn't there anymore? It seems like it should be removed to me, since the behavior without `fromPigAvroStorage` set was to skip this section, which means that it would likely get picked up by the `if (field instanceof List) { ..` block below, which does a different transformation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org