[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #1502: HDDS-4354. Avoid spamming of logs because of deleted transactions.

[GitBox <gi...@apache.org>]

lokeshj1703 commented on a change in pull request #1502:
URL: https://github.com/apache/hadoop-ozone/pull/1502#discussion_r507591562



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java
##########
@@ -130,9 +130,7 @@ public void incrementCount(List<Long> txIDs) throws IOException {
         DeletedBlocksTransaction block =
             scmMetadataStore.getDeletedBlocksTXTable().get(txID);
         if (block == null) {
-          // Should we make this an error ? How can we not find the deleted
-          // TXID?
-          LOG.warn("Deleted TXID {} not found.", txID);
+          LOG.debug("Deleted TXID {} not found.", txID);

Review comment:
       NIT: We can include the log inside check for debug log enabled.
   ```suggestion
             if (LOG.isDebugEnabled()) {
               LOG.debug("Deleted TXID {} not found.", txID);
             }
   ```

##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/lease/LeaseManager.java
##########
@@ -235,7 +235,7 @@ public void run() {
           }
         } catch (InterruptedException e) {
           // This means a new lease is added to activeLeases.
-          LOG.error("Execution was interrupted ", e);
+          LOG.debug("Execution was interrupted ", e);

Review comment:
       This should not be related to block deletion. What exception are we seeing here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org