You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/02/24 18:51:58 UTC
[GitHub] [sling-site] kwin opened a new pull request #55: download binaries (incl. hashes and signatures) from ASF Maven
kwin opened a new pull request #55:
URL: https://github.com/apache/sling-site/pull/55
Repository
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-site] kwin commented on a change in pull request #55: download binaries (incl. hashes and signatures) from ASF Maven
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #55:
URL: https://github.com/apache/sling-site/pull/55#discussion_r582653800
##########
File path: src/main/jbake/templates/downloads.tpl
##########
@@ -324,6 +324,19 @@ def downloadLink(label, artifact, version, suffix) {
newLine()
}
+def mavenDownloadLink(label, artifact, version, suffix) {
+ def path = "${artifact}/${version}/${artifact}-${version}${suffix}"
+ def base = "https://repository.apache.org/content/repositories/releases/org/apache/sling/"
Review comment:
We need to point to Maven Central instead
> Projects must not point or refer to repository.apache.org directly in download pages, release announcements or emails. Instead, any public download links for those releases should point to Maven Central.
(https://infra.apache.org/release-distribution.html#maven)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-site] bdelacretaz commented on pull request #55: download binaries (incl. hashes and signatures) from ASF Maven
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #55:
URL: https://github.com/apache/sling-site/pull/55#issuecomment-785728056
Ok, I have commented on our dev list - I ask that you do not merge this PR for now, while we discuss there. I think it's good to use the ASF mirrors for all downloads and as mentioned there I don't really see the problem with svn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-site] bdelacretaz commented on pull request #55: download binaries (incl. hashes and signatures) from ASF Maven
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #55:
URL: https://github.com/apache/sling-site/pull/55#issuecomment-785303635
Why? My understanding is that this would prevent using the ASF mirrors for downloads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-site] kwin commented on pull request #55: download binaries (incl. hashes and signatures) from ASF Maven
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #55:
URL: https://github.com/apache/sling-site/pull/55#issuecomment-785344239
See https://lists.apache.org/thread.html/r5ac69fcb1251aaad4b5c6e69e4784369c74bee0d13e3ffeb990e3e64%40%3Cdev.sling.apache.org%3E for a background. I don't think that a lot of people are downloading Sling Modules with other means than via Maven (with all its mirrors).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org