You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/02/27 22:27:51 UTC
Review Request 18589: Delete service failure needs more helpful message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18589/
-----------------------------------------------------------
Review request for Ambari and Tom Beerbower.
Bugs: BUG-4876
https://issues.apache.org/jira/browse/BUG-4876
Repository: ambari
Description
-------
* Update error text to something more meaningful.
* Failure will not result in partial results when trying to delete more than one service.
* Sneak in a fix to NagiosPropertyProvider error logging, it just gets annoying seeing the same message over and over when it's not really an error.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 8a8b435
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 90c0e4e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 2bc51bb
Diff: https://reviews.apache.org/r/18589/diff/
Testing
-------
Results :
Tests run: 1472, Failures: 0, Errors: 0, Skipped: 11
[INFO]
Thanks,
Nate Cole
Re: Review Request 18589: Delete service failure needs more helpful message
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 28, 2014, 10:24 a.m., Tom Beerbower wrote:
> > Quick question... Is it possible that a service becomes non-removable during the process of checking its state but before it's removed? If so, could we still end up with partial results?
Yes, this is true in theory. The code seems to have gotten in this pattern where several targets can be acted upon, but there is no transaction among all of them. This code merely attempts to do some validation before actually attempting to perform the delete (which is an improvement over What Was, but not ideal).
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18589/#review35785
-----------------------------------------------------------
On Feb. 27, 2014, 4:27 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18589/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 4:27 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: BUG-4876
> https://issues.apache.org/jira/browse/BUG-4876
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Update error text to something more meaningful.
> * Failure will not result in partial results when trying to delete more than one service.
> * Sneak in a fix to NagiosPropertyProvider error logging, it just gets annoying seeing the same message over and over when it's not really an error.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 8a8b435
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 90c0e4e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 2bc51bb
>
> Diff: https://reviews.apache.org/r/18589/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 1472, Failures: 0, Errors: 0, Skipped: 11
>
> [INFO]
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 18589: Delete service failure needs more helpful message
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18589/#review35785
-----------------------------------------------------------
Quick question... Is it possible that a service becomes non-removable during the process of checking its state but before it's removed? If so, could we still end up with partial results?
- Tom Beerbower
On Feb. 27, 2014, 9:27 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18589/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 9:27 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: BUG-4876
> https://issues.apache.org/jira/browse/BUG-4876
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Update error text to something more meaningful.
> * Failure will not result in partial results when trying to delete more than one service.
> * Sneak in a fix to NagiosPropertyProvider error logging, it just gets annoying seeing the same message over and over when it's not really an error.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 8a8b435
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 90c0e4e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 2bc51bb
>
> Diff: https://reviews.apache.org/r/18589/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 1472, Failures: 0, Errors: 0, Skipped: 11
>
> [INFO]
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 18589: Delete service failure needs more helpful message
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18589/#review35788
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Feb. 27, 2014, 9:27 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18589/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 9:27 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: BUG-4876
> https://issues.apache.org/jira/browse/BUG-4876
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Update error text to something more meaningful.
> * Failure will not result in partial results when trying to delete more than one service.
> * Sneak in a fix to NagiosPropertyProvider error logging, it just gets annoying seeing the same message over and over when it's not really an error.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 8a8b435
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 90c0e4e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 2bc51bb
>
> Diff: https://reviews.apache.org/r/18589/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 1472, Failures: 0, Errors: 0, Skipped: 11
>
> [INFO]
>
>
> Thanks,
>
> Nate Cole
>
>