[GitHub] [groovy] jonnybot0 commented on pull request #1814: Bugfix/groovy 9541 respect parent classloader

[GitBox <gi...@apache.org>]

jonnybot0 commented on PR #1814:
URL: https://github.com/apache/groovy/pull/1814#issuecomment-1291223195

   > Have you searched for each use of evaluateExpression or is there a subset that was handled? 
   
   Yes, this is all the usages in the source code I could find.
   
   > The cast failure implies that you used a different class loader to create the instance of AnnotationCollectorMode than the loader the compiler used to load that class. The transform loader is what you want if the compiler is going to be assigning references that aren't just strings and numbers.
   
   Right. That's why I moved to using `.valueOf(val.toString())` to get the annotation value without a cast. But I see what you mean. I should be able to use the `transformLoader` on the class. I'll do that in my follow-up PR to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org