You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Ferdy (JIRA)" <ji...@apache.org> on 2010/02/10 14:58:27 UTC
[jira] Created: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Add a new Filter that checks a single column value but does not emit it.
------------------------------------------------------------------------
Key: HBASE-2211
URL: https://issues.apache.org/jira/browse/HBASE-2211
Project: Hadoop HBase
Issue Type: New Feature
Affects Versions: 0.20.3
Reporter: Ferdy
Attachments: HBASE-2211.patch
Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Posted by "Ferdy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated HBASE-2211:
-------------------------
Attachment: HBASE-2211-v3.patch
Understood. Here is v3 of the patch:
-removed the author annotation
-added the Filter to HbaseObjectWritable
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Attachments: HBASE-2211-v2.patch, HBASE-2211-v3.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2211:
-------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
Committed to TRUNK. Thanks for the patch Ferdy.
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Fix For: 0.21.0
>
> Attachments: HBASE-2211-v2.patch, HBASE-2211-v3.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Posted by "Ferdy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated HBASE-2211:
-------------------------
Attachment: HBASE-2211.patch
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Attachments: HBASE-2211.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Posted by "Ferdy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated HBASE-2211:
-------------------------
Attachment: (was: HBASE-2211.patch)
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Attachments: HBASE-2211-v2.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Posted by "Ferdy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated HBASE-2211:
-------------------------
Status: Patch Available (was: Open)
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Attachments: HBASE-2211.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2211) Add a new Filter that checks a
single column value but does not emit it.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832624#action_12832624 ]
stack commented on HBASE-2211:
------------------------------
Patch looks great.
Please remove '+ * @author ferdy'. Its apache policy to not have author annotations.
Also, you need to add mention of your filter to HbaseObjectWriter (If you are interested in the arcane why, just say and I'll dump it out in here for you).
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Attachments: HBASE-2211-v2.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2211) Add a new Filter that checks a single
column value but does not emit it.
Posted by "Ferdy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated HBASE-2211:
-------------------------
Attachment: HBASE-2211-v2.patch
Added HBASE-2211-v2.patch:
-Fixed minor indentation issues
> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
> Key: HBASE-2211
> URL: https://issues.apache.org/jira/browse/HBASE-2211
> Project: Hadoop HBase
> Issue Type: New Feature
> Affects Versions: 0.20.3
> Reporter: Ferdy
> Attachments: HBASE-2211-v2.patch, HBASE-2211.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a specific value (like SingleColumnValueFilter) , but exclude the KeyValue from the output. This is certainly the case when the column values are large in size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided to subclass it. SingleColumnValueExcludeFilter is the result. Tests are included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.