You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by regeda <gi...@git.apache.org> on 2015/03/31 18:56:29 UTC

[GitHub] thrift pull request: THRIFT-3064 added default handler for undecla...

GitHub user regeda opened a pull request:

    https://github.com/apache/thrift/pull/414

    THRIFT-3064 added default handler for undeclared exceptions in php gener...

    PHP app crashes on every undeclared exception.
    But it isn't necessary declare all internal exceptions (like RedisException, DoctrineException, etc.) in .thrift file. They should be catched and serialized by Thrift into TApplicationException (aka INTERNAL_ERROR).
    It will be more informative than plane 500 HTTP code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/regeda/thrift php-generic-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #414
    
----
commit 649843dc83a4bc60f56d9e6c9c8386a5adbc2e89
Author: Anthony Regeda <re...@inbox.ru>
Date:   2015-03-31T16:55:26Z

    THRIFT-3064 added default handler for undeclared exceptions in php generator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3064 added default handler for undecla...

Posted by Jens-G <gi...@git.apache.org>.

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/414#issuecomment-88221996
  
    What was that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3064 added default handler for undecla...

Posted by regeda <gi...@git.apache.org>.

Github user regeda closed the pull request at:

    https://github.com/apache/thrift/pull/414


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---