You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/10 01:51:56 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3396: [Enhancement] Add the "@Override" annotation above this method signature[ConsumerService]

Alonexc opened a new issue, #3396:
URL: https://github.com/apache/incubator-eventmesh/issues/3396

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/224202167-5913286b-2eba-43be-9b1b-47d2d632e9cc.png)
   ![image](https://user-images.githubusercontent.com/91315508/224202185-22ba7f9e-8370-4c52-9764-1faaaaa89b0b.png)
   ![image](https://user-images.githubusercontent.com/91315508/224202189-5088c265-e846-4097-8703-8bbd781c277c.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/service/ConsumerService.java line 55,74,148
   analysis and explanation:
   Using the @Override annotation is useful for two reasons :
   It elicits a warning from the compiler if the annotated method doesn’t actually override anything, as in the case of a misspelling.
   It improves the readability of the source code by making it obvious that methods are overridden.
   
   
   ### Describe the solution you'd like
   
   add “@Override”
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc closed issue #3396: [Enhancement] Add the "@Override" annotation above this method signature[ConsumerService]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #3396: [Enhancement] Add the "@Override" annotation above this method signature[ConsumerService]
URL: https://github.com/apache/eventmesh/issues/3396


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] nikhilsaama commented on issue #3396: [Enhancement] Add the "@Override" annotation above this method signature[ConsumerService]

Posted by "nikhilsaama (via GitHub)" <gi...@apache.org>.
nikhilsaama commented on issue #3396:
URL: https://github.com/apache/eventmesh/issues/3396#issuecomment-1529322415

   This is issue seems already fixed. @Override annotation is already added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org