You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/04/07 23:44:50 UTC
Review Request 20104: Added task reconciliation for unknown slaves and tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20104/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-764
https://issues.apache.org/jira/browse/MESOS-764
Repository: mesos-git
Description
-------
This completes the reconciliation cases to allow framework schedulers to reconcile state against the master.
Diffs
-----
src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c
Diff: https://reviews.apache.org/r/20104/diff/
Testing
-------
Tests will be added to ensure the reconciliation cases are handled correctly.
Thanks,
Ben Mahler
Re: Review Request 20104: Added task reconciliation for unknown slaves and
tasks.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20104/#review39748
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20104]
All tests passed.
- Mesos ReviewBot
On April 7, 2014, 9:44 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20104/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 9:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-764
> https://issues.apache.org/jira/browse/MESOS-764
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This completes the reconciliation cases to allow framework schedulers to reconcile state against the master.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c
>
> Diff: https://reviews.apache.org/r/20104/diff/
>
>
> Testing
> -------
>
> Tests will be added to ensure the reconciliation cases are handled correctly.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 20104: Added task reconciliation for unknown slaves and
tasks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20104/#review40442
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/20104/#comment73447>
also include framework id.
- Vinod Kone
On April 7, 2014, 9:44 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20104/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 9:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-764
> https://issues.apache.org/jira/browse/MESOS-764
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This completes the reconciliation cases to allow framework schedulers to reconcile state against the master.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c
>
> Diff: https://reviews.apache.org/r/20104/diff/
>
>
> Testing
> -------
>
> Tests will be added to ensure the reconciliation cases are handled correctly.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 20104: Added task reconciliation for unknown slaves and
tasks.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20104/
-----------------------------------------------------------
(Updated April 15, 2014, 9:57 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Improved a logging message per Vinod's review.
Bugs: MESOS-764
https://issues.apache.org/jira/browse/MESOS-764
Repository: mesos-git
Description
-------
This completes the reconciliation cases to allow framework schedulers to reconcile state against the master.
Diffs (updated)
-----
src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c
Diff: https://reviews.apache.org/r/20104/diff/
Testing
-------
Tests will be added to ensure the reconciliation cases are handled correctly.
Thanks,
Ben Mahler