You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/04 18:26:53 UTC
[GitHub] [hive] saihemanth-cloudera opened a new pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle
saihemanth-cloudera opened a new pull request #2248:
URL: https://github.com/apache/hive/pull/2248
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Added implementations of connector provider for MSSQL and Oracle.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
WIth these changes users will be able to create connectors for mssql and oracle.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Local machine
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on a change in pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on a change in pull request #2248:
URL: https://github.com/apache/hive/pull/2248#discussion_r677504488
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -245,7 +248,12 @@ protected Connection getConnection() {
private ResultSet fetchTablesViaDBMetaData(String regex) throws SQLException {
ResultSet rs = null;
try {
- rs = getConnection().getMetaData().getTables(scoped_db, null, regex, new String[] { "TABLE" });
+ if (this.type.equalsIgnoreCase(IDataConnectorProvider.ORACLE_TYPE) ||
Review comment:
Sorry if I missed this earlier or if this was recently added, but would it make sense to move this logic into the provider ? so the abstract provider will call something like getCatalog() and getSchema() which will return whatever is appropriate. Maybe the abstract provider can provide the default and providers can override the method. or maybe just add a util method in this class (not abstract) that returns the values for all the DBs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2248:
URL: https://github.com/apache/hive/pull/2248#issuecomment-883785183
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on a change in pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on a change in pull request #2248:
URL: https://github.com/apache/hive/pull/2248#discussion_r636624386
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -172,10 +172,12 @@ protected Connection getConnection() {
ResultSet rs = null;
Table table = null;
try {
- // rs = fetchTableMetadata(tableName);
- rs = fetchTableViaDBMetaData(tableName);
+ rs = fetchTableMetadata(tableName);
Review comment:
I am not sure I understand this change. Dont we want to use fetchTableViaDBmetadata? we comment out the implementation in the abstract class and moved it into subclasses. can you please expand on your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2248:
URL: https://github.com/apache/hive/pull/2248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2248:
URL: https://github.com/apache/hive/pull/2248#discussion_r637117347
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MSSQLConnectorProvider.java
##########
@@ -0,0 +1,100 @@
+package org.apache.hadoop.hive.metastore.dataconnector.jdbc;
+
+import org.apache.hadoop.hive.metastore.ColumnType;
+import org.apache.hadoop.hive.metastore.api.DataConnector;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class MSSQLConnectorProvider extends AbstractJDBCConnectorProvider {
+ private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
+ private static final String DRIVER_CLASS = "com.microsoft.sqlserver.jdbc.SQLServerDriver".intern();
+
+ public MSSQLConnectorProvider(String dbName, DataConnector dataConn) {
+ super(dbName, dataConn);
+ driverClassName = DRIVER_CLASS;
+ }
+
+ /**
+ * Returns Hive Table objects from the remote database for tables that match a name pattern.
+ * @return List A collection of objects that match the name pattern, null otherwise.
+ * @throws MetaException To indicate any failures with executing this API
+ * @param regex
+ */
+ @Override public List<Table> getTables(String regex) throws MetaException {
+ return null;
+ }
+
+ @Override protected ResultSet fetchTableMetadata(String tableName) throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getColumns(null, scoped_db, tableName, null);
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve table names from remote datasource, cause:" + sqle.getMessage());
+ throw new MetaException("Could not retrieve table metadata from remote datasource, cause:" + sqle.getMessage());
+ }
+ return rs;
+ }
+
+ @Override protected ResultSet fetchTableNames() throws MetaException {
+ return null;
+ }
+
+ @Override public List<String> getTableNames() throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getTables(null, scoped_db, null, null);
+ if (rs != null) {
+ List<String> tables = new ArrayList<String>();
Review comment:
`= newArrayList<>();`
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/DerbySQLConnectorProvider.java
##########
@@ -48,7 +48,14 @@ protected ResultSet fetchTableNames() throws MetaException {
*/
@Override
public ResultSet fetchTableMetadata(String tableName) throws MetaException {
- return null;
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getColumns(scoped_db, null, tableName, null);
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve column names from JDBC table, cause:" + sqle.getMessage());
Review comment:
`LOG.warn("Could not retrieve column names from JDBC table", sqle);`
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MSSQLConnectorProvider.java
##########
@@ -0,0 +1,100 @@
+package org.apache.hadoop.hive.metastore.dataconnector.jdbc;
+
+import org.apache.hadoop.hive.metastore.ColumnType;
+import org.apache.hadoop.hive.metastore.api.DataConnector;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class MSSQLConnectorProvider extends AbstractJDBCConnectorProvider {
+ private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
+ private static final String DRIVER_CLASS = "com.microsoft.sqlserver.jdbc.SQLServerDriver".intern();
+
+ public MSSQLConnectorProvider(String dbName, DataConnector dataConn) {
+ super(dbName, dataConn);
+ driverClassName = DRIVER_CLASS;
+ }
+
+ /**
+ * Returns Hive Table objects from the remote database for tables that match a name pattern.
+ * @return List A collection of objects that match the name pattern, null otherwise.
+ * @throws MetaException To indicate any failures with executing this API
+ * @param regex
+ */
+ @Override public List<Table> getTables(String regex) throws MetaException {
+ return null;
+ }
+
+ @Override protected ResultSet fetchTableMetadata(String tableName) throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getColumns(null, scoped_db, tableName, null);
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve table names from remote datasource, cause:" + sqle.getMessage());
+ throw new MetaException("Could not retrieve table metadata from remote datasource, cause:" + sqle.getMessage());
+ }
+ return rs;
+ }
+
+ @Override protected ResultSet fetchTableNames() throws MetaException {
+ return null;
+ }
+
+ @Override public List<String> getTableNames() throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getTables(null, scoped_db, null, null);
+ if (rs != null) {
+ List<String> tables = new ArrayList<String>();
+ while(rs.next()) {
+ tables.add(rs.getString(3));
+ }
+ return tables;
+ }
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve table names from remote datasource, cause:" + sqle.getMessage());
+ } finally {
+ try {
+ if (rs != null) {
+ rs.close();
+ rs = null;
+ }
+ } catch(Exception e) {
+ LOG.info("Error in MSSQL Data Provider: "+e.getMessage());
Review comment:
`LOG.error("Error in... ", e);`
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MSSQLConnectorProvider.java
##########
@@ -0,0 +1,100 @@
+package org.apache.hadoop.hive.metastore.dataconnector.jdbc;
+
+import org.apache.hadoop.hive.metastore.ColumnType;
+import org.apache.hadoop.hive.metastore.api.DataConnector;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class MSSQLConnectorProvider extends AbstractJDBCConnectorProvider {
+ private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
+ private static final String DRIVER_CLASS = "com.microsoft.sqlserver.jdbc.SQLServerDriver".intern();
+
+ public MSSQLConnectorProvider(String dbName, DataConnector dataConn) {
+ super(dbName, dataConn);
+ driverClassName = DRIVER_CLASS;
+ }
+
+ /**
+ * Returns Hive Table objects from the remote database for tables that match a name pattern.
+ * @return List A collection of objects that match the name pattern, null otherwise.
+ * @throws MetaException To indicate any failures with executing this API
+ * @param regex
+ */
+ @Override public List<Table> getTables(String regex) throws MetaException {
+ return null;
+ }
+
+ @Override protected ResultSet fetchTableMetadata(String tableName) throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getColumns(null, scoped_db, tableName, null);
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve table names from remote datasource, cause:" + sqle.getMessage());
Review comment:
`LOG.warn("Could not retrieve table names from JDBC table", sqle);`
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MSSQLConnectorProvider.java
##########
@@ -0,0 +1,100 @@
+package org.apache.hadoop.hive.metastore.dataconnector.jdbc;
+
+import org.apache.hadoop.hive.metastore.ColumnType;
+import org.apache.hadoop.hive.metastore.api.DataConnector;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class MSSQLConnectorProvider extends AbstractJDBCConnectorProvider {
+ private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
+ private static final String DRIVER_CLASS = "com.microsoft.sqlserver.jdbc.SQLServerDriver".intern();
+
+ public MSSQLConnectorProvider(String dbName, DataConnector dataConn) {
+ super(dbName, dataConn);
+ driverClassName = DRIVER_CLASS;
+ }
+
+ /**
+ * Returns Hive Table objects from the remote database for tables that match a name pattern.
+ * @return List A collection of objects that match the name pattern, null otherwise.
+ * @throws MetaException To indicate any failures with executing this API
+ * @param regex
+ */
+ @Override public List<Table> getTables(String regex) throws MetaException {
+ return null;
+ }
+
+ @Override protected ResultSet fetchTableMetadata(String tableName) throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getColumns(null, scoped_db, tableName, null);
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve table names from remote datasource, cause:" + sqle.getMessage());
+ throw new MetaException("Could not retrieve table metadata from remote datasource, cause:" + sqle.getMessage());
+ }
+ return rs;
+ }
+
+ @Override protected ResultSet fetchTableNames() throws MetaException {
+ return null;
+ }
+
+ @Override public List<String> getTableNames() throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = getConnection().getMetaData().getTables(null, scoped_db, null, null);
+ if (rs != null) {
+ List<String> tables = new ArrayList<String>();
+ while(rs.next()) {
+ tables.add(rs.getString(3));
+ }
+ return tables;
+ }
+ } catch (SQLException sqle) {
+ LOG.warn("Could not retrieve table names from remote datasource, cause:" + sqle.getMessage());
Review comment:
`LOG.warn("Failed to retrieve ....", sqle);`
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -216,16 +218,16 @@ protected Connection getConnection() {
}
}
- private ResultSet fetchTableViaDBMetaData(String tableName) throws SQLException {
- ResultSet rs = null;
- try {
- rs = getConnection().getMetaData().getColumns(scoped_db, null, tableName, null);
- } catch (SQLException sqle) {
- LOG.warn("Could not retrieve column names from JDBC table, cause:" + sqle.getMessage());
- throw sqle;
- }
- return rs;
- }
+// private ResultSet fetchTableViaDBMetaData(String tableName) throws SQLException {
+// ResultSet rs = null;
+// try {
+// rs = getConnection().getMetaData().getColumns(scoped_db, null, tableName, null);
+// } catch (SQLException sqle) {
+// LOG.warn("Could not retrieve column names from JDBC table, cause:" + sqle.getMessage());
+// throw sqle;
+// }
+// return rs;
+// }
Review comment:
Just drop the code if need be, do not check-in commented out code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org