You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/04/12 10:49:25 UTC

[jira] [Commented] (OAK-4183) Move NodeState decoration related classes from oak-upgrade to oak-core

    [ https://issues.apache.org/jira/browse/OAK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236851#comment-15236851 ] 

Michael Dürig commented on OAK-4183:
------------------------------------

Note that wrapping node states is somewhat troublesome wrt. optimisations for equality and diffing. This was e.g. discussed in OAK-2586. Moving those utilities to oak-core makes them more visible increasing the chances of (inadvertently) misusing them. 
I would at least clarify this point (i.e. the intended use case for those classes in the JavaDoc).



> Move NodeState decoration related classes from oak-upgrade to oak-core
> ----------------------------------------------------------------------
>
>                 Key: OAK-4183
>                 URL: https://issues.apache.org/jira/browse/OAK-4183
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: core, upgrade
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.6
>
>
> In sidegrade while transforming a DoucmentNodeState to SegmentNodeState we would need to copy over certain "meta" properties like {{lastRevision}}. To simplify this it would be better to make use of {{AbstractDecoratedNodeState}} which delegates to {{DocumentNodeState}} and there add these meta properties



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)