You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Roshan Punnoose (JIRA)" <ji...@apache.org> on 2007/10/18 20:25:50 UTC
[jira] Created: (FELIX-399) OBR referrals
OBR referrals
-------------
Key: FELIX-399
URL: https://issues.apache.org/jira/browse/FELIX-399
Project: Felix
Issue Type: Bug
Components: Bundle Repository (OBR)
Reporter: Roshan Punnoose
I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-399) OBR referrals
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-399:
------------------------------------
Fix Version/s: bundlerepository-1.0.6
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Assignee: Felix Meschberger
> Fix For: bundlerepository-1.0.6
>
> Attachments: FELIX-399-fmeschbe-2.patch, FELIX-399-fmeschbe.patch, FELIX-399.patch, felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-399) OBR referrals
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-399.
-------------------------------------
Resolution: Fixed
Assignee: Felix Meschberger
I have applied my last patch (after fixing issues with the test case based on an older implementation) in Rev. 671815.
Referrals are now followed and the hop count is respected. All referred repositories visited are added as if they would have been added through RepositoryAdmin.addRepository(URL).
I have tested this patch in my local environment and it seems to work. Please also test in your environment thanks.
If it works, please close this issue.
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Assignee: Felix Meschberger
> Attachments: FELIX-399-fmeschbe-2.patch, FELIX-399-fmeschbe.patch, FELIX-399.patch, felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-399) OBR referrals
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-399:
------------------------------------
Attachment: FELIX-399-fmeschbe.patch
Another patch modification. Starting from Richard's patch, this adds/changes the following:
* Adds unit tests
* Modifies Referral to store depth as int (default 1) and URL as String
* Only loads referrals after completing file parsing (not in addReferral)
* Resolves referral URLs relative to repository URL
* loading hop count is only used for resolving referrals
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: FELIX-399-fmeschbe.patch, FELIX-399.patch, felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-399) OBR referrals
Posted by "Roshan Punnoose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roshan Punnoose updated FELIX-399:
----------------------------------
Attachment: felix-obr-referral.patch
Felix OBR referral path
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-399) OBR referrals
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-399:
------------------------------------
Attachment: FELIX-399-fmeschbe-2.patch
Here is another patch which enhances my first one as follows:
* Removes a TODO comment hinting hopCount is not implemented
* Reformats by removing extra spaces around parentheses
* Reintroduces functionliaty to extract repository.xml from ZIP files
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: FELIX-399-fmeschbe-2.patch, FELIX-399-fmeschbe.patch, FELIX-399.patch, felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-399) OBR referrals
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606867#action_12606867 ]
Richard S. Hall commented on FELIX-399:
---------------------------------------
I have attached an updated version of the patch, which mostly corrects the formatting issues with an odd change here and there. Tobias, if you want to make sure that my new patch didn't break anything, that would be great. Then we just have to figure out how to add the hop count functionality.
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: FELIX-399.patch, felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-399) OBR referrals
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600251#action_12600251 ]
Felix Meschberger commented on FELIX-399:
-----------------------------------------
> The only issue is that my code does not take into account the attribute "depth"
IMHO the depth attribute is an absolute requirement to prevent endless recursions etc. We can also not just stop following referrals on repositories, we already visited because the depth value on the referral has to be obeyed as declared.
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-399) OBR referrals
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606820#action_12606820 ]
Richard S. Hall commented on FELIX-399:
---------------------------------------
Can someone get the depth attribute working? I agree with Felix, it seems like this should be in place. However, I could probably be convinced to move forward without it.
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-399) OBR referrals
Posted by "Tobias Wegner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606778#action_12606778 ]
Tobias Wegner commented on FELIX-399:
-------------------------------------
This patch works well for me, when will it be included into the release?
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-399) OBR referrals
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600249#action_12600249 ]
Felix Meschberger commented on FELIX-399:
-----------------------------------------
Thanks for this patch. I just implemented my own approach, but yours possibly reusing already loaded URLs might be better.
But your patch has the problem, that it also contains code reformatting. Could you please provide a patch, which does not include the reformatting ? Thanks alot.
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-399) OBR referrals
Posted by "Roshan Punnoose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roshan Punnoose updated FELIX-399:
----------------------------------
Attachment: felix-obr-referral-2.patch
In my last patch. I added resources from the referral directly to the repository that held the referral. I believe that the referral should use the RepositoryAdmin to add a repository from the referral url. That way if there is more than one referral in the future to the same url, the felix-bundle-repository can use they same url and not create duplicate resources.
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-399) OBR referrals
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall updated FELIX-399:
----------------------------------
Attachment: FELIX-399.patch
> OBR referrals
> -------------
>
> Key: FELIX-399
> URL: https://issues.apache.org/jira/browse/FELIX-399
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Reporter: Roshan Punnoose
> Attachments: FELIX-399.patch, felix-obr-referral-2.patch, felix-obr-referral.patch
>
>
> I noticed that Felix does not have support right now for OBR referrals. So I added a patch, and I was hoping you guys could look at it and make sure it makes sense. The only issue is that my code does not take into account the attribute "depth", it will go through every referral and add all the resources. I couldn't figure out a good way to make use of the depth attribute to make it work in the framework.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.