You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/07/16 18:44:45 UTC

[GitHub] nickva edited a comment on issue #1445: Make MD5 hash implementation configurable - issue #1171

nickva edited a comment on issue #1445: Make MD5 hash implementation configurable - issue #1171
URL: https://github.com/apache/couchdb/pull/1445#issuecomment-405338539
 
 
   EUnit tests pass with and without the `--erlang-md5` configure option.
   
   +1
   
   I'd suggest mentioning the issue number (#1171) in the commit message. Also rebase against latest master. 
   
   Then create a docs pull request to make note about the new option. Maybe under `Runtime Errors` section in https://github.com/apache/couchdb-documentation/blob/master/src/install/troubleshooting.rst. Make sure to mention there could be a performance penalty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services