You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/03 05:51:03 UTC

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22440


Change subject: [master] tablet_id() accessors return const reference
......................................................................

[master] tablet_id() accessors return const reference

This patch doesn't contain any functional modifications.

Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Reviewed-on: http://gerrit.cloudera.org:8080/22429
Tested-by: Kudu Jenkins
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
(cherry picked from commit 271ce3c91d61c54732f8bcb8e08b121b2f5e6b57)
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
3 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/22440/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22440 )

Change subject: [master] tablet_id() accessors return const reference
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1010/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 10:05:18 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22440 )

Change subject: [master] tablet_id() accessors return const reference
......................................................................


Patch Set 1: Verified+1

unrelated tests failures


-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 16:26:41 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22440 )

Change subject: [master] tablet_id() accessors return const reference
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1010/


-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Feb 2025 05:51:08 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [master] tablet_id() accessors return const reference
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22440 )

Change subject: [master] tablet_id() accessors return const reference
......................................................................

[master] tablet_id() accessors return const reference

This patch doesn't contain any functional modifications.

Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Reviewed-on: http://gerrit.cloudera.org:8080/22429
Tested-by: Kudu Jenkins
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
(cherry picked from commit 271ce3c91d61c54732f8bcb8e08b121b2f5e6b57)
Reviewed-on: http://gerrit.cloudera.org:8080/22440
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
3 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR](branch-1.18.x) [master] tablet id() accessors return const reference

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22440 )

Change subject: [master] tablet_id() accessors return const reference
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9d2aee19c0eade2ea41042b553c116b5028e49f
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 14:58:26 +0000
Gerrit-HasComments: No