You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/21 13:05:29 UTC
Review Request 56884: Hive2: Visual Explain -Layout glitches of
overlapping edges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56884/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20097
https://issues.apache.org/jira/browse/AMBARI-20097
Repository: ambari
Description
-------
- Fix layout glitches
- remove uuid
- positioning fix
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 2800c09
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d3768c1
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 905e73c
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f
Diff: https://reviews.apache.org/r/56884/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56884: Hive 2: Visual Explain - Remove children in
the JSON dump
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56884/#review166186
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 21, 2017, 1:09 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56884/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 1:09 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20097
> https://issues.apache.org/jira/browse/AMBARI-20097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Fix layout glitches
> - remove uuid
> - positioning fix
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 2800c09
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d3768c1
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 905e73c
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f
>
> Diff: https://reviews.apache.org/r/56884/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56884: Hive 2: Visual Explain - Remove children in
the JSON dump
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56884/#review166168
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On Feb. 21, 2017, 1:09 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56884/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 1:09 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20097
> https://issues.apache.org/jira/browse/AMBARI-20097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Fix layout glitches
> - remove uuid
> - positioning fix
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 2800c09
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d3768c1
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 905e73c
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f
>
> Diff: https://reviews.apache.org/r/56884/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56884: Hive 2: Visual Explain - Remove children in
the JSON dump
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56884/#review166171
-----------------------------------------------------------
Ship it!
Ship It!
- Abhishek Kumar
On Feb. 21, 2017, 1:09 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56884/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 1:09 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20097
> https://issues.apache.org/jira/browse/AMBARI-20097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Fix layout glitches
> - remove uuid
> - positioning fix
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 2800c09
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d3768c1
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 905e73c
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f
>
> Diff: https://reviews.apache.org/r/56884/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56884: Hive 2: Visual Explain - Remove children in
the JSON dump
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56884/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 1:09 p.m.)
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Summary (updated)
-----------------
Hive 2: Visual Explain - Remove children in the JSON dump
Bugs: AMBARI-20097
https://issues.apache.org/jira/browse/AMBARI-20097
Repository: ambari
Description
-------
- Fix layout glitches
- remove uuid
- positioning fix
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 2800c09
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d3768c1
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 905e73c
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f
Diff: https://reviews.apache.org/r/56884/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56884: Hive2: Visual Explain -Layout glitches of
overlapping edges
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56884/#review166160
-----------------------------------------------------------
Ship it!
Ship It!
- Abhishek Kumar
On Feb. 21, 2017, 1:05 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56884/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 1:05 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20097
> https://issues.apache.org/jira/browse/AMBARI-20097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Fix layout glitches
> - remove uuid
> - positioning fix
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 2800c09
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d3768c1
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 905e73c
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f
>
> Diff: https://reviews.apache.org/r/56884/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>