You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 10:21:42 UTC

[GitHub] [flink] zentol opened a new pull request #12021: [FLINK-16346][runtime][tests] Use BlockingNoOpInvokable

zentol opened a new pull request #12021:
URL: https://github.com/apache/flink/pull/12021


   There are 2 problems in this test:
       The Job to be canceled also uses the FailingBlockingInvokable, but we never actually want the Invokable to throw an exception. It should just use a BlockingNoOpInvokable.
       The FailingBlockingInvokable uses static state to control the behavior; if you don't fork the JVM this can result in unexpected behavior in subsequent tests. I believe this is what is happening here; the failing test runs first, sets the blocking flag to false, then the cancel test runs and goes straight to throwing the exception instead of blocking.
   
   This PR is a quick fix, but long-term we should find a safe pattern for such stateful Invokables.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12021: [FLINK-16346][runtime][tests] Use BlockingNoOpInvokable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12021:
URL: https://github.com/apache/flink/pull/12021#issuecomment-625188357


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7f2decc03d4d8d36b875187a7ef4c56ceedc2448",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=744",
       "triggerID" : "7f2decc03d4d8d36b875187a7ef4c56ceedc2448",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7f2decc03d4d8d36b875187a7ef4c56ceedc2448 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=744) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12021: [FLINK-16346][runtime][tests] Use BlockingNoOpInvokable

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12021:
URL: https://github.com/apache/flink/pull/12021#issuecomment-625188357


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7f2decc03d4d8d36b875187a7ef4c56ceedc2448",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7f2decc03d4d8d36b875187a7ef4c56ceedc2448",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7f2decc03d4d8d36b875187a7ef4c56ceedc2448 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12021: [FLINK-16346][runtime][tests] Use BlockingNoOpInvokable

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12021:
URL: https://github.com/apache/flink/pull/12021#issuecomment-625167771


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7f2decc03d4d8d36b875187a7ef4c56ceedc2448 (Thu May 07 10:24:29 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12021: [FLINK-16346][runtime][tests] Use BlockingNoOpInvokable

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12021:
URL: https://github.com/apache/flink/pull/12021#issuecomment-625188357


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7f2decc03d4d8d36b875187a7ef4c56ceedc2448",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=744",
       "triggerID" : "7f2decc03d4d8d36b875187a7ef4c56ceedc2448",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7f2decc03d4d8d36b875187a7ef4c56ceedc2448 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=744) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org