[trafficserver] branch master updated: Fix crash during raw connect failures (#8306)

[bn...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bneradt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 2dcfda5  Fix crash during raw connect failures (#8306)
2dcfda5 is described below

commit 2dcfda555c9d127a5512d1379628da8fdbb64292
Author: Brian Neradt <br...@gmail.com>
AuthorDate: Fri Sep 10 12:39:44 2021 -0500

    Fix crash during raw connect failures (#8306)
    
    In the case of raw open, the server_txn will generally be a nullptr.  We
    tried to use server_txn when calling set_connect_fail, which resulted in
    a crash. This change simply removes the call. Note that a generic call
    to set_connect_fail was already called previous to calling this
    function.
---
 proxy/http/HttpSM.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index c9a6c25..2c82924 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -1252,7 +1252,6 @@ HttpSM::state_raw_http_server_open(int event, void *data)
 
   case VC_EVENT_ERROR:
   case NET_EVENT_OPEN_FAILED:
-    t_state.set_connect_fail(server_txn->get_netvc()->lerrno);
     t_state.current.state = HttpTransact::OPEN_RAW_ERROR;
     // use this value just to get around other values
     t_state.hdr_info.response_error = HttpTransact::STATUS_CODE_SERVER_ERROR;