[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11625: [fix-10938]: use dot to replace source and make the default env work in shell

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #11625:
URL: https://github.com/apache/dolphinscheduler/pull/11625#discussion_r967848673


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/ShellCommandExecutor.java:
##########
@@ -108,7 +108,7 @@ protected void createCommandFileIfNotExists(String execCommand, String commandFi
                     sb.append(taskRequest.getEnvironmentConfig()).append("\n");
                 } else {
                     if (taskRequest.getEnvFile() != null) {
-                        sb.append("source ").append(taskRequest.getEnvFile()).append("\n");
+                        sb.append(". ").append(taskRequest.getEnvFile()).append("\n");

Review Comment:
   Hi @yutianaiqingtian , We would like to release it in version 3.0.1. Could you submit this ASAP since we are ready to release version 3.0.1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org