You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2011/04/29 18:48:23 UTC
svn_wc_get_pristine_copy_path and deleted file
Hi,
The (deprecated) API svn_wc_get_pristine_copy_path has a regression:
in 1.6, it properly returned the pristine path of files that were
removed (svn rm).
But now, it returns a bogus path (..\.svn\nonexistent-path), not the
path of the BASE file of the removed file.
I haven't tested svn_wc_get_pristine_contents2 since that returns a
stream and I need a file to pass to the external diff application.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: svn_wc_get_pristine_copy_path and deleted file
Posted by Stefan Küng <to...@gmail.com>.
On 29.04.2011 22:52, Bert Huijben wrote:
>
>
>> -----Original Message-----
>> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
>> Sent: vrijdag 29 april 2011 18:58
>> To: Subversion Development
>> Subject: Re: svn_wc_get_pristine_copy_path and deleted file
>>
>> On Fri, Apr 29, 2011 at 18:48, Stefan Küng<to...@gmail.com> wrote:
>>> Hi,
>>>
>>> The (deprecated) API svn_wc_get_pristine_copy_path has a regression:
>>> in 1.6, it properly returned the pristine path of files that were removed
>>> (svn rm).
>>> But now, it returns a bogus path (..\.svn\nonexistent-path), not the path of
>>> the BASE file of the removed file.
>>> I haven't tested svn_wc_get_pristine_contents2 since that returns a
>> stream
>>> and I need a file to pass to the external diff application.
>>
>> Update:
>> svn_wc_get_pristine_contents2 doesn't work either in this situation.
>
> r1097942 should fix both cases even though they used different code paths.
Confirmed: this fixes the issue for both cases.
Thanks!
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
RE: svn_wc_get_pristine_copy_path and deleted file
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
> Sent: vrijdag 29 april 2011 18:58
> To: Subversion Development
> Subject: Re: svn_wc_get_pristine_copy_path and deleted file
>
> On Fri, Apr 29, 2011 at 18:48, Stefan Küng <to...@gmail.com> wrote:
> > Hi,
> >
> > The (deprecated) API svn_wc_get_pristine_copy_path has a regression:
> > in 1.6, it properly returned the pristine path of files that were removed
> > (svn rm).
> > But now, it returns a bogus path (..\.svn\nonexistent-path), not the path of
> > the BASE file of the removed file.
> > I haven't tested svn_wc_get_pristine_contents2 since that returns a
> stream
> > and I need a file to pass to the external diff application.
>
> Update:
> svn_wc_get_pristine_contents2 doesn't work either in this situation.
r1097942 should fix both cases even though they used different code paths.
Bert
Re: svn_wc_get_pristine_copy_path and deleted file
Posted by Stefan Küng <to...@gmail.com>.
On Fri, Apr 29, 2011 at 18:48, Stefan Küng <to...@gmail.com> wrote:
> Hi,
>
> The (deprecated) API svn_wc_get_pristine_copy_path has a regression:
> in 1.6, it properly returned the pristine path of files that were removed
> (svn rm).
> But now, it returns a bogus path (..\.svn\nonexistent-path), not the path of
> the BASE file of the removed file.
> I haven't tested svn_wc_get_pristine_contents2 since that returns a stream
> and I need a file to pass to the external diff application.
Update:
svn_wc_get_pristine_contents2 doesn't work either in this situation.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net