You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/28 19:38:15 UTC

[GitHub] merlimat opened a new pull request #1128: Use Optional instead of null checks when reading isolation policies

merlimat opened a new pull request #1128: Use Optional instead of null checks when reading isolation policies
URL: https://github.com/apache/incubator-pulsar/pull/1128
 
 
   ### Motivation
   
   As it has been done in other place, refactor code that is relying on checking for null to use `Optional` and force explicit dealing for the empty condition and avoid exceptions like: 
   
   ```
   2018-01-26 03:33:38,823 - WARN  - [pulsar-1-2:SimpleResourceAllocationPolicies@56] - GetIsolationPolicies: Unable to get the namespaceIsolationPolicies [{}]
   java.lang.NullPointerException
       at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:770)
       at com.google.common.base.Joiner.toString(Joiner.java:454)
       at com.google.common.base.Joiner.appendTo(Joiner.java:109)
       at com.google.common.base.Joiner.appendTo(Joiner.java:154)
       at com.google.common.base.Joiner.appendTo(Joiner.java:141)
       at com.google.common.base.Joiner.appendTo(Joiner.java:168)
       at org.apache.pulsar.broker.web.PulsarWebResource.path(PulsarWebResource.java:101)
       at org.apache.pulsar.broker.loadbalance.impl.SimpleResourceAllocationPolicies.getIsolationPolicies(SimpleResourceAllocationPolicies.java:54)
       at org.apache.pulsar.broker.loadbalance.impl.SimpleResourceAllocationPolicies.isSharedBroker(SimpleResourceAllocationPolicies.java:97)
       at org.apache.pulsar.broker.loadbalance.impl.LoadManagerShared.applyPolicies(LoadManagerShared.java:129)
       at org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl.selectBrokerForAssignment(ModularLoadManagerImpl.java:659)
       at org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerWrapper.getLeastLoaded(ModularLoadManagerWrapper.java:67)
       at org.apache.pulsar.broker.namespace.NamespaceService.getLeastLoadedFromLoadManager(NamespaceService.java:463)
       at org.apache.pulsar.broker.namespace.NamespaceService.searchForCandidateBroker(NamespaceService.java:338)
       at org.apache.pulsar.broker.namespace.NamespaceService.lambda$15(NamespaceService.java:301)
       at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
       at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
       at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
       at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
       at java.lang.Thread.run(Thread.java:748)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services