You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/05 03:18:03 UTC
Review Request 43239: Added Resources::size().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43239/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Added Resources::size().
Diffs
-----
include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1
include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af
Diff: https://reviews.apache.org/r/43239/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 43239: Added Resources::size().
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43239/#review118094
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 5, 2016, 2:18 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43239/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Resources::size().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1
> include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af
>
> Diff: https://reviews.apache.org/r/43239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43239: Added Resources::size().
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43239/#review117944
-----------------------------------------------------------
Ship it!
I saw the test case was already covered in https://reviews.apache.org/r/42751
- Guangya Liu
On 二月 5, 2016, 2:18 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43239/
> -----------------------------------------------------------
>
> (Updated 二月 5, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Resources::size().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1
> include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af
>
> Diff: https://reviews.apache.org/r/43239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43239: Added Resources::size().
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43239/#review117943
-----------------------------------------------------------
Can you please add a test case for size()?
- Guangya Liu
On 二月 5, 2016, 2:18 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43239/
> -----------------------------------------------------------
>
> (Updated 二月 5, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Resources::size().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1
> include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af
>
> Diff: https://reviews.apache.org/r/43239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>