You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/26 22:52:10 UTC
Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-122
https://issues.apache.org/jira/browse/AURORA-122
Repository: aurora
Description
-------
Add an abstraction for secondary indices, introduce an index on slave host.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
Diff: https://reviews.apache.org/r/17372/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 27, 2014, 9:55 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 89
> > <https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line89>
> >
> > Would be great to have a brief write out here on how primary and secondary are supposed to work together and their consistency/thread-safety expectations.
Done.
> On Jan. 27, 2014, 9:55 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 289
> > <https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line289>
> >
> > Optional?
Sure, done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32887
-----------------------------------------------------------
On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17372/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 9:52 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-122
> https://issues.apache.org/jira/browse/AURORA-122
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add an abstraction for secondary indices, introduce an index on slave host.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
>
> Diff: https://reviews.apache.org/r/17372/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32887
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/17372/#comment61879>
Would be great to have a brief write out here on how primary and secondary are supposed to work together and their consistency/thread-safety expectations.
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/17372/#comment61885>
Optional?
- Maxim Khutornenko
On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17372/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 9:52 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-122
> https://issues.apache.org/jira/browse/AURORA-122
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add an abstraction for secondary indices, introduce an index on slave host.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
>
> Diff: https://reviews.apache.org/r/17372/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 27, 2014, 10:18 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 293
> > <https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line293>
> >
> > Does it make sense to special-case the primary-key index here? Seems that the taskId index could implement SecondaryIndex (or just rename SecondaryIndex to Index).
I like the idea of a consistent API, but i don't think the current SecondaryIndex fits since it implies non-unique keys. Also, a generalized interface might make the fall-back to a full scan awkward.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32894
-----------------------------------------------------------
On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17372/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 9:52 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-122
> https://issues.apache.org/jira/browse/AURORA-122
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add an abstraction for secondary indices, introduce an index on slave host.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
>
> Diff: https://reviews.apache.org/r/17372/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32894
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/17372/#comment61900>
Does it make sense to special-case the primary-key index here? Seems that the taskId index could implement SecondaryIndex (or just rename SecondaryIndex to Index).
- Kevin Sweeney
On Jan. 26, 2014, 1:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17372/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 1:52 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-122
> https://issues.apache.org/jira/browse/AURORA-122
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add an abstraction for secondary indices, introduce an index on slave host.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
>
> Diff: https://reviews.apache.org/r/17372/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32900
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 26, 2014, 1:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17372/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 1:52 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-122
> https://issues.apache.org/jira/browse/AURORA-122
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add an abstraction for secondary indices, introduce an index on slave host.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
>
> Diff: https://reviews.apache.org/r/17372/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32903
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 27, 2014, 10:38 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17372/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 10:38 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-122
> https://issues.apache.org/jira/browse/AURORA-122
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add an abstraction for secondary indices, introduce an index on slave host.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
>
> Diff: https://reviews.apache.org/r/17372/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17372: Add an abstraction for secondary indices,
introduce an index on slave host.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 10:38 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-122
https://issues.apache.org/jira/browse/AURORA-122
Repository: aurora
Description
-------
Add an abstraction for secondary indices, introduce an index on slave host.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f344cb760cefeceb4a4282bef463a5511cee0f4a
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e
src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de
src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e
Diff: https://reviews.apache.org/r/17372/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner