You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/25 18:22:10 UTC
[GitHub] [airflow] dalex100 opened a new issue #10554: Web UI doesn't render packaged dag code properly
dalex100 opened a new issue #10554:
URL: https://github.com/apache/airflow/issues/10554
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
This questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.10
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): Client : 1.15.5 / Server : v1.16.13-eks-2ba888
**Environment**:
- **Cloud provider or hardware configuration**: AWS EKS
- **OS** (e.g. from /etc/os-release):
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
Using **serialized_dags=true** and s**tore_dag_code=true** with packaged dags, it is not possible to view the dag code in the web UI. (data is blurred in case there's sensitive information). Packaged dags render fine when dags aren't serialized.
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
The web UI should display the dag code.
<!-- What do you think went wrong? -->
**How to reproduce it**:
Use the following settings :
```
AIRFLOW__CORE__STORE_SERIALIZED_DAGS: "true"
AIRFLOW__CORE__STORE_DAG_CODE: "true"
```
and upload a packaged dag into Airflow.
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-680195811
I will definitely take a look, thanks for creating the issue @dalex100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #10554:
URL: https://github.com/apache/airflow/issues/10554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #10554:
URL: https://github.com/apache/airflow/issues/10554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-680195009
@kaxil @anikarni -> that might be indeed an interesting problem with DAG serialization
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-870066500
I was not able to replicate this on Main branch, looks like it was fixed by https://github.com/apache/airflow/pull/13984 which was released in 2.1.0
[test_zip.zip](https://github.com/apache/airflow/files/6729430/test_zip.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-680193329
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-870066500
I was not able to replicate this on Main branch, looks like it was fixed by https://github.com/apache/airflow/pull/13984 which was released in 2.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-869594026
I guess we have not addressed it in 2.1.1 - moving it to 2.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-870066500
I was not able to replicate this on Main branch, looks like it was fixed by https://github.com/apache/airflow/pull/13984 which was released in 2.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #10554: Web UI doesn't render packaged dag code properly
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #10554:
URL: https://github.com/apache/airflow/issues/10554#issuecomment-870066500
I was not able to replicate this on Main branch, looks like it was fixed by https://github.com/apache/airflow/pull/13984 which was released in 2.1.0
[test_zip.zip](https://github.com/apache/airflow/files/6729430/test_zip.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org