You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/01/22 04:21:27 UTC

[GitHub] [hive] amanraj2520 opened a new pull request, #3973: HIVE-26971 : Test fixes caused due to CALCITE-1413

amanraj2520 opened a new pull request, #3973:
URL: https://github.com/apache/hive/pull/3973

   JIRA link : https://issues.apache.org/jira/browse/HIVE-26971
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Test fixes caused due to CALCITE-1413

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1399402840

   @abstractdog @zabetak Can you please review and merge this. Just a simple test fix also attached the ticket which caused this in CALCITE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak closed pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)
URL: https://github.com/apache/hive/pull/3973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1419178789

   Just for everyone's information, the changes have been merged into branch-3 for this PR using this commit id : 5205d575bb2d0a74383eaf73a8089b2fc8216f87


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #3973: HIVE-26971 : Backport of HIVE-20593

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1411863174

   @amanraj2520 I merged the changes but I have some comments. 
   
   The PR as well as the JIRA summary are misleading; the changes are NOT a backport of HIVE-20593. The changes is a simple update of a .q.out file. Please change the title here and the JIRA summary accordingly (see my commit message).
   
   Moreover, the relation with HIVE-20593 is unclear. HIVE-20593 has been for a while in branch-3 but the test started failing recently. For instance when we enabled the tests in [branch-3](http://ci.hive.apache.org/job/hive-precommit/job/branch-3/1/#showFailuresLink) the test was not failing. Please be more meticulous and precise in further investigations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Backport of HIVE-20593

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1409066466

   @zabetak Can you please review this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1412466675

   @amanraj2520 You created HIVE-26971 so there is a specific JIRA for the test failure; not sure what you mean that there is no specific JIRA for this.
   
   The commit https://github.com/apache/hive/commit/dca6ef04e376ea1e18cd8986c3baf210b51d7677 mentions HIVE-20593 but as I wrote above the same reason does not seem to apply here. 
   
   HIVE-20593 is in branch-3 for a while now so if the problem was HIVE-20593 then the test should fail from the beginning that we started running CI in branch-3; not after merging 15 patches. There somethings more to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1419145185

   @amanraj2520 Thanks for the detailed explanation.
   
   After checking all runs in [branch-3](http://ci.hive.apache.org/job/hive-precommit/job/branch-3/) here is what I found. 
   
   The `load_data_using_job.q` was not running [when we enabled the tests in the branch](http://ci.hive.apache.org/job/hive-precommit/job/branch-3/1/#showFailuresLink); I wrongly assumed that it was passing since I didn't see it in the failure list.
   
   It appears that the test started running after merging (https://github.com/apache/hive/commit/a25392b28576c620b37cf19336eab186697c3330) and since then it was always failing.
   
   So indeed it can be due to [HIVE-20593](https://issues.apache.org/jira/browse/HIVE-20593).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1419172872

   Thanks @zabetak 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1416722510

   @zabetak What I meant is that when this change was committed to OSS master, then there was no specific JIRA created for this issue back then. It was done only under HIVE-20593 addendum patch. In order to fix this issue I compared the load_data_using_job.q.out between OSS/master and current branch-3(without this commit). The diff in these lines lead me to this commit https://github.com/apache/hive/commit/dca6ef04e376ea1e18cd8986c3baf210b51d7677 which was done in OSS/master without any JIRA ticket being created for this commit. If you go to this commit it simply says HIVE-20593 addendum patch. Not sure why there was no specific JIRA created for this test failure.
   ![image](https://user-images.githubusercontent.com/104416558/216763145-5d9cb4e2-a6e0-480a-adc0-91eeac55555c.png)
   
   In order to answer your question why these tests did not fail on branch-3 even if HIVE-20593 has been on branch-3 for a long time is as follows:
   http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3847/1/tests - There was no Jenkins file committed to branch-3 before. Thats why I decided that when we do the 3.2.0 release from branch-3, I would ensure that all the test pass in branch-3. This is the first commit that I had made after committing the Jenkins file to branch-3(which means that this was the first pull request which ran the jenkins pipeline for the tests). I see the test failure even here : (Link : http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3847/1/tests) Attached the snapshot as well.
   
   ![image](https://user-images.githubusercontent.com/104416558/216763346-231838a8-1cb5-42f9-8fdf-be83a85fa477.png)
   
   Can you please ping a link where you find this test passing because I think that as far as all the PR's I have merged in branch-3, I find this test failing in every PR since we setup the Jenkins pipeline.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1411915543

   Hi @zabetak Thanks for your review. This was done as part of HIVE-20593 addendum patch. Please follow this commit id : https://github.com/apache/hive/commit/dca6ef04e376ea1e18cd8986c3baf210b51d7677. Can you please mark this as complete and close this. Apologies for not mentioning the commit id.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Test fix in load_data_using_job.q.out (Done as part of HIVE-20593 addendum patch)

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1411917470

   @zabetak There is no specific JIRA created for this. So I have mentioned the commit id of master. Thanks for merging it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #3973: HIVE-26971 : Backport of HIVE-20593

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #3973:
URL: https://github.com/apache/hive/pull/3973#issuecomment-1407263724

   @zabetak I could not figure out why it has a specific connection with Calcite-1413. I had checked in some bad branch or something. I have changed the title to pick the change when this test was fixed in oss master. Kindly review it now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org