You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/16 20:11:29 UTC

Re: Review Request 35509: Doxygen Style Guide Improvements.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35509/
-----------------------------------------------------------

(Updated June 16, 2015, 6:11 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-2501
    https://issues.apache.org/jira/browse/MESOS-2501


Repository: mesos


Description
-------

Added style examples and improved structure.


Diffs
-----

  docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 

Diff: https://reviews.apache.org/r/35509/diff/


Testing
-------

Rendered Version:
https://gist.github.com/joerg84/7039ed2d029470127cea


Thanks,

Joerg Schad


Re: Review Request 35509: Doxygen Style Guide Improvements.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On June 19, 2015, 10 a.m., Alexander Rojas wrote:
> > docs/mesos-doxygen-style-guide.md, line 9
> > <https://reviews.apache.org/r/35509/diff/1/?file=985751#file985751line9>
> >
> >     Just out of curiosity, why was this deleted?

Prior this was followed by the -now- mesos-markdown-styleguide. It felt weird to call something Preliminary without any content following.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35509/#review88517
-----------------------------------------------------------


On June 16, 2015, 6:11 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35509/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2501
>     https://issues.apache.org/jira/browse/MESOS-2501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added style examples and improved structure.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 
> 
> Diff: https://reviews.apache.org/r/35509/diff/
> 
> 
> Testing
> -------
> 
> Rendered Version:
> https://gist.github.com/joerg84/7039ed2d029470127cea
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 35509: Doxygen Style Guide Improvements.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35509/#review88517
-----------------------------------------------------------

Ship it!



docs/mesos-doxygen-style-guide.md 
<https://reviews.apache.org/r/35509/#comment141097>

    Just out of curiosity, why was this deleted?


- Alexander Rojas


On June 16, 2015, 8:11 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35509/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 8:11 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2501
>     https://issues.apache.org/jira/browse/MESOS-2501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added style examples and improved structure.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 
> 
> Diff: https://reviews.apache.org/r/35509/diff/
> 
> 
> Testing
> -------
> 
> Rendered Version:
> https://gist.github.com/joerg84/7039ed2d029470127cea
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>