You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/08 20:54:51 UTC
[GitHub] codecov-io commented on issue #6345: Remove user params in security
manager functions
codecov-io commented on issue #6345: Remove user params in security manager functions
URL: https://github.com/apache/incubator-superset/pull/6345#issuecomment-437152179
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=h1) Report
> Merging [#6345](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/49346050439d66179e1de19c0bffa4ced3a8dbe6?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6345 +/- ##
=========================================
- Coverage 77.33% 77.3% -0.03%
=========================================
Files 67 67
Lines 9578 9576 -2
=========================================
- Hits 7407 7403 -4
- Misses 2171 2173 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6345/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.87% <100%> (-0.02%)` | :arrow_down: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/6345/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `75.55% <100%> (-0.11%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/6345/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `90% <0%> (-10%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/6345/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `89.47% <0%> (-5.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=footer). Last update [4934605...f18f067](https://codecov.io/gh/apache/incubator-superset/pull/6345?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org