You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/01/03 19:28:57 UTC
Review Request 55149: Added the `mesos-cni-port-mapper` to the CMake
build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55149/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-6040
https://issues.apache.org/jira/browse/MESOS-6040
Repository: mesos
Description
-------
Added the `mesos-cni-port-mapper` to the CMake build.
Diffs
-----
cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc
src/slave/containerizer/mesos/CMakeLists.txt 650b1a28d96bb2fb8cb43b90e2edd18694dfc09a
Diff: https://reviews.apache.org/r/55149/diff/
Testing
-------
make check
Ran a cmake build to ensure that the `mesos-cni-port-mapper` plugin is being compiled.
Thanks,
Avinash sridharan
Re: Review Request 55149: Added the `mesos-cni-port-mapper` to the
CMake build.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55149/#review161853
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 3, 2017, 7:28 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55149/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 7:28 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6040
> https://issues.apache.org/jira/browse/MESOS-6040
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `mesos-cni-port-mapper` to the CMake build.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc
> src/slave/containerizer/mesos/CMakeLists.txt 650b1a28d96bb2fb8cb43b90e2edd18694dfc09a
>
> Diff: https://reviews.apache.org/r/55149/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran a cmake build to ensure that the `mesos-cni-port-mapper` plugin is being compiled.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 55149: Added the `mesos-cni-port-mapper` to the
CMake build.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55149/#review160469
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55149]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 3, 2017, 7:28 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55149/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 7:28 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6040
> https://issues.apache.org/jira/browse/MESOS-6040
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `mesos-cni-port-mapper` to the CMake build.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc
> src/slave/containerizer/mesos/CMakeLists.txt 650b1a28d96bb2fb8cb43b90e2edd18694dfc09a
>
> Diff: https://reviews.apache.org/r/55149/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran a cmake build to ensure that the `mesos-cni-port-mapper` plugin is being compiled.
>
>
> Thanks,
>
> Avinash sridharan
>
>