You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "loneylee (via GitHub)" <gi...@apache.org> on 2024/03/19 03:31:16 UTC
[PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
loneylee opened a new pull request, #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012
## What changes were proposed in this pull request?
(Fixes: \#4989)
## How was this patch tested?
Test by ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2010672427
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_03_20_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_03_19_2024_e977d79e3_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>38.53</font></td>
<td><font color=#6F9915>36.21</font></td>
<td><font color=#6F9915>-2.311</font></td>
<td><font color=#6F9915>94.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>24.00</font></td>
<td><font color=#F92663>24.11</font></td>
<td><font color=#F92663>0.109</font></td>
<td><font color=#F92663>100.46%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>37.50</font></td>
<td><font color=#6F9915>36.64</font></td>
<td><font color=#6F9915>-0.854</font></td>
<td><font color=#6F9915>97.72%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>38.61</font></td>
<td><font color=#6F9915>38.02</font></td>
<td><font color=#6F9915>-0.590</font></td>
<td><font color=#6F9915>98.47%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>71.63</font></td>
<td><font color=#6F9915>69.07</font></td>
<td><font color=#6F9915>-2.563</font></td>
<td><font color=#6F9915>96.42%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>7.37</font></td>
<td><font color=#6F9915>5.91</font></td>
<td><font color=#6F9915>-1.459</font></td>
<td><font color=#6F9915>80.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>83.96</font></td>
<td><font color=#6F9915>82.31</font></td>
<td><font color=#6F9915>-1.651</font></td>
<td><font color=#6F9915>98.03%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>84.46</font></td>
<td><font color=#F92663>85.26</font></td>
<td><font color=#F92663>0.803</font></td>
<td><font color=#F92663>100.95%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>125.15</font></td>
<td><font color=#6F9915>121.93</font></td>
<td><font color=#6F9915>-3.219</font></td>
<td><font color=#6F9915>97.43%</font></td>
</tr>
<tr>
<td><font color=#F92663>q10</font></td>
<td><font color=#F92663>45.58</font></td>
<td><font color=#F92663>45.61</font></td>
<td><font color=#F92663>0.027</font></td>
<td><font color=#F92663>100.06%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.52</font></td>
<td><font color=#F92663>20.57</font></td>
<td><font color=#F92663>0.048</font></td>
<td><font color=#F92663>100.23%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>28.80</font></td>
<td><font color=#6F9915>28.32</font></td>
<td><font color=#6F9915>-0.482</font></td>
<td><font color=#6F9915>98.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>48.70</font></td>
<td><font color=#6F9915>47.17</font></td>
<td><font color=#6F9915>-1.533</font></td>
<td><font color=#6F9915>96.85%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>22.25</font></td>
<td><font color=#6F9915>16.86</font></td>
<td><font color=#6F9915>-5.393</font></td>
<td><font color=#6F9915>75.76%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>31.14</font></td>
<td><font color=#F92663>31.19</font></td>
<td><font color=#F92663>0.052</font></td>
<td><font color=#F92663>100.17%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>15.42</font></td>
<td><font color=#F92663>16.26</font></td>
<td><font color=#F92663>0.846</font></td>
<td><font color=#F92663>105.48%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>102.47</font></td>
<td><font color=#6F9915>99.14</font></td>
<td><font color=#6F9915>-3.327</font></td>
<td><font color=#6F9915>96.75%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>143.60</font></td>
<td><font color=#6F9915>142.77</font></td>
<td><font color=#6F9915>-0.829</font></td>
<td><font color=#6F9915>99.42%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.64</font></td>
<td><font color=#F92663>14.68</font></td>
<td><font color=#F92663>1.044</font></td>
<td><font color=#F92663>107.65%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>27.02</font></td>
<td><font color=#F92663>28.29</font></td>
<td><font color=#F92663>1.265</font></td>
<td><font color=#F92663>104.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>225.52</font></td>
<td><font color=#F92663>227.96</font></td>
<td><font color=#F92663>2.443</font></td>
<td><font color=#F92663>101.08%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>13.96</font></td>
<td><font color=#F92663>14.00</font></td>
<td><font color=#F92663>0.041</font></td>
<td><font color=#F92663>100.29%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1249.81</font></td>
<td><font color=#6F9915>1232.28</font></td>
<td><font color=#6F9915>-17.534</font></td>
<td><font color=#6F9915>98.60%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2008611432
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2008728482
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2005688746
https://github.com/apache/incubator-gluten/issues/4989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "binmahone (via GitHub)" <gi...@apache.org>.
binmahone merged PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2008710118
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2005688925
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "binmahone (via GitHub)" <gi...@apache.org>.
binmahone commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2009442820
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2006254446
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2008562573
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2006260908
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5012:
URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2006245042
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org