You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/01/04 02:32:54 UTC
[jira] Created: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Abort bootstrap if our IP is already in the token ring
------------------------------------------------------
Key: CASSANDRA-663
URL: https://issues.apache.org/jira/browse/CASSANDRA-663
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796241#action_12796241 ]
Eric Evans commented on CASSANDRA-663:
--------------------------------------
+1
> Abort bootstrap if our IP is already in the token ring
> ------------------------------------------------------
>
> Key: CASSANDRA-663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-663
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 663.txt
>
>
> Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796440#action_12796440 ]
Jonathan Ellis commented on CASSANDRA-663:
------------------------------------------
I'd like to have this as a sanity check on all move operations, not just the initial bootstrap. What about putting the check at the beginning of SS.startBootstrap?
> Abort bootstrap if our IP is already in the token ring
> ------------------------------------------------------
>
> Key: CASSANDRA-663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-663
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 663.txt
>
>
> Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796766#action_12796766 ]
Jonathan Ellis commented on CASSANDRA-663:
------------------------------------------
you're right, this makes the most sense after "got load info." committed with that change.
> Abort bootstrap if our IP is already in the token ring
> ------------------------------------------------------
>
> Key: CASSANDRA-663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-663
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 663.txt
>
>
> Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-663:
-------------------------------------
Attachment: 663.txt
> Abort bootstrap if our IP is already in the token ring
> ------------------------------------------------------
>
> Key: CASSANDRA-663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-663
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Attachments: 663.txt
>
>
> Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796464#action_12796464 ]
Jaakko Laine commented on CASSANDRA-663:
----------------------------------------
As long as it is before gossip, it does not make so big difference.
However, I don't know what this check would achieve in a move operation. If the node is up and running in order to do a move operation, it must be in token metadata as well. Move does not change IP address, so this check for duplicate IP address is relevant only in first bootstrap.
> Abort bootstrap if our IP is already in the token ring
> ------------------------------------------------------
>
> Key: CASSANDRA-663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-663
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 663.txt
>
>
> Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-663) Abort bootstrap if our IP is
already in the token ring
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796434#action_12796434 ]
Jaakko Laine commented on CASSANDRA-663:
----------------------------------------
IMHO this check should be done before starting the bootstrap process (immediately after "... got load info"). At that point we've already slept for RING_DELAY, so waiting for another RING_DELAY in startBootstrap is probably not useful. If we do the check at its current place, we've already started to gossip our bootsrap token, which will cause the other rightful IP owner to be removed from token metadata.
> Abort bootstrap if our IP is already in the token ring
> ------------------------------------------------------
>
> Key: CASSANDRA-663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-663
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 663.txt
>
>
> Trying to bootstrap a node w/ the same IP as one that is Down but not removed from the ring should give an error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.