You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/11/16 18:11:39 UTC
[jira] Created: (CASSANDRA-558) optimize local writes
optimize local writes
---------------------
Key: CASSANDRA-558
URL: https://issues.apache.org/jira/browse/CASSANDRA-558
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.5
Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0002-r-m-underscores.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0003-r-m-redundant-interface-IMessagingService.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784820#action_12784820 ]
Jaakko Laine commented on CASSANDRA-558:
----------------------------------------
Oh yeah, my bad, read it wrong. Sorry about that.
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0002-r-m-underscores.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784701#action_12784701 ]
Jaakko Laine commented on CASSANDRA-558:
----------------------------------------
Not sure, but isn't there a race condition in WriteResponseHandler? If all responses arrive before StorageProxy gets to the point where it does "condition.await(timeout, TimeUnit.MILLISECONDS)", the signal from response resolver will be lost and get will timeout even though all responses have arrived. Quite theoretical possibility, but possibility nonetheless.
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0005-rename.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: 0005-rename.txt
0004-add-WriteResponseHandler-combining-the-important-parts.txt
0003-r-m-redundant-interface-IMessagingService.txt
0002-r-m-underscores.txt
0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784813#action_12784813 ]
Jonathan Ellis commented on CASSANDRA-558:
------------------------------------------
that's why I implemented SimpleCondition, to avoid this problem (and the spurious wakeup one) from the implementation returned by lock.newCondition
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778398#action_12778398 ]
Jonathan Ellis edited comment on CASSANDRA-558 at 11/16/09 6:45 PM:
--------------------------------------------------------------------
requires CASSANDRA-540.
05
rename
04
add WriteResponseHandler combining the important parts of QuorumResponseHandler and WriteResponseResolver.
In particular, note that we (correctly) never send a write response of false, letting the timeout take care
of that should-never-happen case. optimize local writes in insertBlocking, and fix HH.
03
r/m redundant interface IMessagingService
02
r/m underscores
01
CASSANDRA-558 make local insert() skip MessagingService and fix HH
was (Author: jbellis):
requires CASSANDRA-540.
05
rename
04
add WriteResponseHandler combining the important parts of QuorumResponseHandler and WriteResponseResolver.
In particular, not thate we (correctly) never send a write response of false, letting the timeout take care
of that should-never-happen case. optimize local writes in insertBlocking, and fix HH.
03
r/m redundant interface IMessagingService
02
r/m underscores
01
CASSANDRA-558 make local insert() skip MessagingService and fix HH
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778902#action_12778902 ]
Jaakko Laine commented on CASSANDRA-558:
----------------------------------------
1) I was thinking of having some helper function doTheStuff(WriteResponseHandler responseHandler) and then set the responsehandler if it was not null. Don't know if this would be enough, though.
3) It can be local if cluster size is only slightly bigger than replication factor: (a) Suppose we have a cluster of four nodes (1, 2, 3 and 4) with replication factor 3. (b) Suppose that write is done, for which 1, 2 and 3 are responsible for storing replicas. (c) Suppose that this write is directed to node 4, and nodes 2 and 3 are down at this time. In this case one write will go to node 1, and node 4 will store hinted replicas for 2 and 3. Even if only one of these nodes (1, 2 or 3) is down, the hinted replica will go to the local node to which write operation was directed. This is because getHintedMapForEndpoints fills the list of endpoints with local endpoint in case it cannot get enough of unused live endpoints. But as mentioned, this is a very rare case, so probably not worth the trouble.
5) I'll test this more in the morning.
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: 0006-missing-wrh.java.patch
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt, 0006-missing-wrh.java.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0005-rename.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778505#action_12778505 ]
Brandon Williams commented on CASSANDRA-558:
--------------------------------------------
Adds around 17-18% performance for me on a single node benchmark with stress.py
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0004-add-WriteResponseHandler-combining-the-important-parts.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaakko Laine updated CASSANDRA-558:
-----------------------------------
Attachment: 0004-two-trivial-changes.patch
Here are a couple of comments (some of them truly trivial). I'll see if I have time to do a patch later.
(1) insert and insertBlocking have big chunk of almost identical code. Perhaps it would be good to have a separate this part to a separate method.
(2) HintedHandoffManager.deliverHintsToEndpoint calls sendMessage with null middle argument (table name). This will cause assertion error later in table.get. It would seem variable tableName (which is already present there) will do the trick.
(3) Hinted endpoint might be local. We could perhaps use local write for that too. This is a very rare case, though, so perhaps not worth the trouble.
(4) WriteResponseResolver can be removed?
(5) HintedHandoffManager.deleteEndPoint doesn't seem to work. Hinted endpoints remain in the list and hints are delivered every time a node, for which we have hints, comes online.
(6) A log entry about liveNodes being less than blockFor would be nice?
(7) See patch for two trivial changes
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0003-r-m-redundant-interface-IMessagingService.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0004-add-WriteResponseHandler-combining-the-important-parts.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0006-missing-wrh.java.patch)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: 0005-rename.txt
0004-add-WriteResponseHandler-combining-the-important-parts.txt
0003-r-m-redundant-interface-IMessagingService.txt
0002-r-m-underscores.txt
0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779430#action_12779430 ]
Hudson commented on CASSANDRA-558:
----------------------------------
Integrated in Cassandra #262 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/262/])
rename
patch by jbellis; reviewed by Jaakko Laine for
add WriteResponseHandler combining the important parts of QuorumResponseHandler and WriteResponseResolver.
In particular, not thate we (correctly) never send a write response of false, letting the timeout take care
of that should-never-happen case. optimize local writes in insertBlocking, and fix HH.
patch by jbellis; reviewed by Jaakko Laine for
make local insert() skip MessagingService and fix HH write
patch by jbellis; reviewed by Jaakko Laine for
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778867#action_12778867 ]
Jonathan Ellis commented on CASSANDRA-558:
------------------------------------------
1) I agree, but I don't see how to do it... the differences are in setting up the call back in the innermost loop
2) fixed
3) nope, it won't ever be local -- if the node was live to get the write it would have been delivered normally instead of hinted
4) yes. fixed
5) weird, I don't see anything obviously wrong there. you sure it's actually getting called? Let's address this in another ticket.
6) imo the Right Thing is to add a string to UE explaining what happened, which is a separate patch
7) applied
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778398#action_12778398 ]
Jonathan Ellis commented on CASSANDRA-558:
------------------------------------------
requires CASSANDRA-540.
05
rename
04
add WriteResponseHandler combining the important parts of QuorumResponseHandler and WriteResponseResolver.
In particular, not thate we (correctly) never send a write response of false, letting the timeout take care
of that should-never-happen case. optimize local writes in insertBlocking, and fix HH.
03
r/m redundant interface IMessagingService
02
r/m underscores
01
CASSANDRA-558 make local insert() skip MessagingService and fix HH
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-r-m-underscores.txt, 0003-r-m-redundant-interface-IMessagingService.txt, 0004-add-WriteResponseHandler-combining-the-important-parts.txt, 0005-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: 0003-rename.txt
0002-add-WriteResponseHandler-combining-the-important-parts.txt
0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778398#action_12778398 ]
Jonathan Ellis edited comment on CASSANDRA-558 at 11/16/09 7:55 PM:
--------------------------------------------------------------------
03
rename
02
add WriteResponseHandler combining the important parts of QuorumResponseHandler and WriteResponseResolver.
In particular, note that we (correctly) never send a write response of false, letting the timeout take care
of that should-never-happen case. optimize local writes in insertBlocking, and fix HH.
01
make local insert() skip MessagingService and fix HH
was (Author: jbellis):
requires CASSANDRA-540.
05
rename
04
add WriteResponseHandler combining the important parts of QuorumResponseHandler and WriteResponseResolver.
In particular, note that we (correctly) never send a write response of false, letting the timeout take care
of that should-never-happen case. optimize local writes in insertBlocking, and fix HH.
03
r/m redundant interface IMessagingService
02
r/m underscores
01
CASSANDRA-558 make local insert() skip MessagingService and fix HH
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-558:
-------------------------------------
Attachment: (was: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt)
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-558) optimize local writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778908#action_12778908 ]
Jonathan Ellis commented on CASSANDRA-558:
------------------------------------------
3) I see, I thought you were talking about delivering the hint, not writing the hint itself. I agree that this isn't worth optimizing.
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt, 0002-add-WriteResponseHandler-combining-the-important-parts.txt, 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.