You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/04/28 10:55:20 UTC

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer commented on a change in pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…
URL: https://github.com/apache/calcite/pull/1187#discussion_r279188925
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
 ##########
 @@ -239,27 +240,30 @@ public RelDataType toSql(RelDataType type) {
 
   /** Converts a type in Java format to a SQL-oriented type. */
   public static RelDataType toSql(final RelDataTypeFactory typeFactory,
-      RelDataType type) {
+                                  RelDataType type) {
 
 Review comment:
   I'll fix the indent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services