You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/15 01:27:30 UTC

[GitHub] [shardingsphere] yuzel opened a new pull request #6853: Add test case for EncryptColumnRuleConfigurationYamlSwapper

yuzel opened a new pull request #6853:
URL: https://github.com/apache/shardingsphere/pull/6853


   Fixes #6849.
   
   Changes proposed in this pull request:
   - add test case
   -
   -
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yuzel commented on a change in pull request #6853: Add test case for EncryptColumnRuleConfigurationYamlSwapper

Posted by GitBox <gi...@apache.org>.
yuzel commented on a change in pull request #6853:
URL: https://github.com/apache/shardingsphere/pull/6853#discussion_r470937781



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/test/java/org/apache/shardingsphere/encrypt/yaml/swapper/rule/EncryptColumnRuleConfigurationYamlSwapperTest.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.encrypt.yaml.swapper.rule;
+
+import org.apache.shardingsphere.encrypt.api.config.rule.EncryptColumnRuleConfiguration;
+import org.apache.shardingsphere.encrypt.yaml.config.rule.YamlEncryptColumnRuleConfiguration;
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class EncryptColumnRuleConfigurationYamlSwapperTest {

Review comment:
       Modified




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6853: Add test case for EncryptColumnRuleConfigurationYamlSwapper

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #6853:
URL: https://github.com/apache/shardingsphere/pull/6853#discussion_r470927893



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/test/java/org/apache/shardingsphere/encrypt/yaml/swapper/rule/EncryptColumnRuleConfigurationYamlSwapperTest.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.encrypt.yaml.swapper.rule;
+
+import org.apache.shardingsphere.encrypt.api.config.rule.EncryptColumnRuleConfiguration;
+import org.apache.shardingsphere.encrypt.yaml.config.rule.YamlEncryptColumnRuleConfiguration;
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class EncryptColumnRuleConfigurationYamlSwapperTest {

Review comment:
       Please add final if the class is not design for extension




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #6853: Add test case for EncryptColumnRuleConfigurationYamlSwapper

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6853:
URL: https://github.com/apache/shardingsphere/pull/6853


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #6853: Add test case for EncryptColumnRuleConfigurationYamlSwapper

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #6853:
URL: https://github.com/apache/shardingsphere/pull/6853#issuecomment-675160411


   ## Pull Request Test Coverage Report for [Build 13785](https://coveralls.io/builds/32774172)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **5** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.2%**) to **58.246%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/yaml/swapper/EncryptRuleConfigurationYamlSwapper.java](https://coveralls.io/builds/32774172/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fyaml%2Fswapper%2FEncryptRuleConfigurationYamlSwapper.java#L84) | 1 | 95.65% |
   | [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/yaml/swapper/EncryptRuleAlgorithmProviderConfigurationYamlSwapper.java](https://coveralls.io/builds/32774172/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fyaml%2Fswapper%2FEncryptRuleAlgorithmProviderConfigurationYamlSwapper.java#L45) | 4 | 21.05% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32774172/badge)](https://coveralls.io/builds/32774172) |
   | :-- | --: |
   | Change from base [Build 13776](https://coveralls.io/builds/32764862): |  0.2% |
   | Covered Lines: | 13163 |
   | Relevant Lines: | 22599 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #6853: Add test case for EncryptColumnRuleConfigurationYamlSwapper

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6853:
URL: https://github.com/apache/shardingsphere/pull/6853#issuecomment-675160411


   ## Pull Request Test Coverage Report for [Build 13780](https://coveralls.io/builds/32773421)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.04%**) to **58.071%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32773421/badge)](https://coveralls.io/builds/32773421) |
   | :-- | --: |
   | Change from base [Build 13776](https://coveralls.io/builds/32764862): |  0.04% |
   | Covered Lines: | 13124 |
   | Relevant Lines: | 22600 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org