[jira] [Closed] (OFBIZ-7363) The Connection Pool Status feature in webtools is broken

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-7363.
----------------------------------
    Resolution: Fixed

Fixed in
trunk r1748689+1748693
R15.12 r1748695+1748697
R14.12 r1748696+1748698

I fixed it by using directly the DebugManagedDataSource. It's not an issue as long as you don't set the logging level to verbose which is anyway not something you would do in production. In case you do so and don't want to be disturbed in the log (focusing on something else), it's still easy to comment out the line from DebugManagedDataSource. I also fixed some type warnings while at it.

I also removed this old comment
        // Hmm... then how do we close the JDBC connections?
Because "we" don't close JDBC connections, DBPC takes care of that (or at least should, I did not check).

> The Connection Pool Status feature in webtools is broken
> --------------------------------------------------------
>
>                 Key: OFBIZ-7363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7363
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework/webtools
>    Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: 14.12.01, 15.12.01
>
>
> This was introduced by OFBIZ-4864 hence 1st in R13.07 where it still work well (see demo), as the connection pooling. But has been broken since, with the pooling.
> Fortunately, it's easy to fix and has no implications has long has you don't enable verbose logging (the DebugManagedDataSource only extends ManagedDataSource for verbose logging and to generate the info needed for the Connection Pool Status feature).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)