[GitHub] [incubator-pekko] He-Pin commented on pull request #363: =str Skip parsing when buffer size is 0.

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on PR #363:
URL: https://github.com/apache/incubator-pekko/pull/363#issuecomment-1567373295

   It can be false if the downstream poll, but the upstream is not ready, or downstream is faster and upstream is idle.
   
   I can add more detailed test for JsonFramming but I don't see much value to add a test for the short-circuit logic，as  it's identical to the objectCompleted.
   
   As the chances this short-circuit can benefit, i think that maybe why it's not there in the firsr place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org