[GitHub] [iceberg] ConeyLiu commented on a diff in pull request #7310: Hive: Clean up expired metastore clients

["ConeyLiu (via GitHub)" <gi...@apache.org>]

ConeyLiu commented on code in PR #7310:
URL: https://github.com/apache/iceberg/pull/7310#discussion_r1161564293


##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -147,4 +147,8 @@ private void release(C client) {
   public int poolSize() {
     return poolSize;
   }
+
+  public boolean isClosed() {

Review Comment:
   package-private is enough? For UT, we could mark it as `VisibleForTesting`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org