[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #196: SMART-141 Add formatting for WinRM log stream

[GitBox <gi...@apache.org>]

ahgittin commented on a change in pull request #196:
URL: https://github.com/apache/brooklyn-ui/pull/196#discussion_r613160826



##########
File path: ui-modules/app-inspector/app/components/stream/stream.directive.js
##########
@@ -43,19 +43,51 @@ export function streamDirective() {
         $scope.autoUpdate = $scope.autoUpdate !== false;
         $scope.tail = $scope.tail !== false;
 
-        let pre = $element.find('pre');
+        // Content filtering features
+        $scope.filteredStream = [];
+        $scope.streamProcessedUpTo = 0;
+        $scope.isDisplayOther = $scope.isDisplayOther !== false;
+        $scope.isDisplayError = $scope.isDisplayError !== false;
+        $scope.isDisplayDebug = $scope.isDisplayDebug !== false;
+        $scope.isDisplayTrace = $scope.isDisplayTrace !== false;
+        $scope.isDisplayWarning = $scope.isDisplayWarning !== false;
+        $scope.isFilterContent = isFilterContent;
+        $scope.isDisplayFormattedItem = isDisplayFormattedItem;
+        $scope.getFormattedItemLogLevel = getFormattedItemLogLevel;
+
+        // CLI XML features
+        $scope.cliXml = false;
+        $scope.cliXmlIdentified = false;
+        $scope.toggleCliXml = toggleCliXml;
+        $scope.isCliXmlSupported = isCliXmlSupported;
+        $scope.cliXmlVerificationRequired = isWinRmStream(); // CLI XML verification is required only when stream is WinRM
+
+        let autoScrollableElement = Array.from(document.getElementsByClassName('auto-scrollable'));

Review comment:
       I think we need to restrict to things in the current `$element` -- otherwise an `auto-scrollable` anywhere in the DOM will end up changing the `$scope` of this, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org