[GitHub] [flink] XComp commented on a diff in pull request #19593: [FLINK-27426][rpc] Migrate RPC system internals to Duration

[GitBox <gi...@apache.org>]

XComp commented on code in PR #19593:
URL: https://github.com/apache/flink/pull/19593#discussion_r860583562


##########
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcEndpointTest.java:
##########
@@ -51,7 +50,7 @@
 @ExtendWith(TestLoggerExtension.class)
 public class RpcEndpointTest {
 
-    private static final Time TIMEOUT = Time.seconds(10L);
+    private static final Duration TIMEOUT = Duration.ofSeconds(10L);

Review Comment:
   This one is only used in a single test. I think, we could move the timeout there...



##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingDispatcher.java:
##########
@@ -159,12 +160,14 @@ void completeJobExecution(ExecutionGraphInfo executionGraphInfo) {
     }
 
     CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID jobId, @Nonnull Time timeout) {

Review Comment:
   What about using `Duration` here and in `getNumberJobs` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org