You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by st...@apache.org on 2018/01/02 11:39:49 UTC

[maven-jenkins-lib] branch master updated: fix scoping

This is an automated email from the ASF dual-hosted git repository.

stephenc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git


The following commit(s) were added to refs/heads/master by this push:
     new 420338d  fix scoping
420338d is described below

commit 420338db1c0233440bb46834e0efcbea7f996494
Author: Stephen Connolly <st...@gmail.com>
AuthorDate: Tue Jan 2 11:39:41 2018 +0000

    fix scoping
---
 vars/asfMavenTlpStdBuild.groovy | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/vars/asfMavenTlpStdBuild.groovy b/vars/asfMavenTlpStdBuild.groovy
index 008b5a1..e07b944 100644
--- a/vars/asfMavenTlpStdBuild.groovy
+++ b/vars/asfMavenTlpStdBuild.groovy
@@ -20,6 +20,7 @@
  */
 
 def call(Map params = [:]) {
+  def failingFast = null
   try {
     // set build retention time first
     def buildRetention
@@ -37,7 +38,6 @@ def call(Map params = [:]) {
     def failFast = params.containsKey('failFast') ? params.failFast : true
     Map tasks = [failFast: failFast]
     boolean first = true
-    def failingFast = null
     for (String os in oses) {
       for (def jdk in jdks) {
         String label = jenkinsEnv.labelForOS(os);
@@ -60,6 +60,7 @@ def call(Map params = [:]) {
         cmd += 'clean'
         cmd += 'verify'
         def disablePublishers = !first
+        first = false
         String stageId = "${os}-jdk${jdk}"
         tasks[stageId] = {
           node(label) {
@@ -101,7 +102,6 @@ def call(Map params = [:]) {
             }
           }
         }
-        first = false
       }
     }
     // run the parallel builds
@@ -132,11 +132,11 @@ def call(Map params = [:]) {
     throw e
   } finally {
     // notify completion
+    if (failingFast != null) {
+      echo "Fast failure triggered by ${failingFast}"
+    }
     stage("Notifications") {
       jenkinsNotify()
-      if (failingFast != null) {
-        echo "Fast failure triggered by ${failingFast}"
-      }
     }
   }
 }
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
['"commits@maven.apache.org" <co...@maven.apache.org>'].