You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2022/11/08 07:02:02 UTC
[GitHub] [incubator-teaclave] henrysun007 opened a new pull request, #665: Omit recovery
henrysun007 opened a new pull request, #665:
URL: https://github.com/apache/incubator-teaclave/pull/665
## Description
Tests running in ubuntu18.04 container image raised an [error](https://github.com/apache/incubator-teaclave/actions/runs/3381637780/jobs/5615754041).
Another bug of the rust sdk binding was reported by @GeminiCarrie .
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [X] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [ ] If you've changed APIs, update the documentation.
- [X] Ensure the tests pass (see CI results).
- [X] Make sure your code lints/format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun merged pull request #665: Bugfix of leveldb and rust sdk
Posted by GitBox <gi...@apache.org>.
mssun merged PR #665:
URL: https://github.com/apache/incubator-teaclave/pull/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on a diff in pull request #665: Bugfix of leveldb and rust sdk
Posted by GitBox <gi...@apache.org>.
mssun commented on code in PR #665:
URL: https://github.com/apache/incubator-teaclave/pull/665#discussion_r1017405969
##########
common/rusty_leveldb_sgx/src/db_impl.rs:
##########
@@ -310,6 +314,10 @@ impl DB {
let files = self.vset.borrow().live_files();
let filenames = self.opt.env.children(Path::new(&self.path))?;
for name in filenames {
+ if name.to_str().unwrap().ends_with(SGX_RECOVERY_FILE_SUFFIX) {
Review Comment:
Can you use `?` here to propagate the error?
##########
common/rusty_leveldb_sgx/src/db_impl.rs:
##########
@@ -191,6 +191,10 @@ impl DB {
let mut log_files = vec![];
for file in &filenames {
+ if file.to_str().unwrap().ends_with(SGX_RECOVERY_FILE_SUFFIX) {
Review Comment:
Can you use `?` here to propagate the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org