[GitHub] [arrow] nealrichardson commented on a change in pull request #10989: ARROW-13501: [R] Bindings for count aggregation

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #10989:
URL: https://github.com/apache/arrow/pull/10989#discussion_r696880599



##########
File path: r/tests/testthat/test-dplyr-aggregate.R
##########
@@ -92,9 +92,27 @@ test_that("Group by sum on dataset", {
   )
 })
 
-test_that("Group by any/all", {
+test_that("n()", {
   withr::local_options(list(arrow.debug = TRUE))
+  expect_dplyr_equal(
+    input %>%
+      summarize(counts = n()) %>%
+      collect(),
+    tbl
+  )
 
+  skip("segfault")

Review comment:
       Thanks, though I'm not going to merge this before ARROW-13737 is resolved, so I'll be removing this skip entirely.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org