You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/12 09:22:22 UTC
[GitHub] [incubator-kyuubi] zwangsheng opened a new pull request, #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
zwangsheng opened a new pull request, #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
To close #3157
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#discussion_r944282320
##########
docs/monitor/logging.md:
##########
@@ -105,20 +105,28 @@ Starting org.apache.kyuubi.server.KyuubiServer, logging to /Users/kentyao/tmp/ky
`KYUUBI_MAX_LOG_FILES` controls how many log files will be remained after a Kyuubi server reboots.
-#### Custom Log4j Settings
+#### Custom Log4j2 Settings
-Taking control of `$KYUUBI_HOME/conf/log4j.properties` will also give us the ability of customizing server logging as we want.
+Taking control of `$KYUUBI_HOME/conf/log4j2.xml` will also give us the ability of customizing server logging as we want.
For example, we can disable the console appender and enable the file appender like,
-```properties
-log4j.rootCategory=INFO, FA
-log4j.appender.FA=org.apache.log4j.FileAppender
-log4j.appender.FA.append=false
-log4j.appender.FA.file=log/dummy.log
-log4j.appender.FA.layout=org.apache.log4j.PatternLayout
-log4j.appender.FA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %t %p %c{2}: %m%n
-log4j.appender.FA.Threshold=DEBUG
+```xml
+<Configuration status="INFO">
Review Comment:
can we use content of `conf/log4j.xml.template`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#issuecomment-1212910303
CC @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on code in PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#discussion_r944463773
##########
docs/monitor/logging.md:
##########
@@ -18,7 +18,7 @@
# Monitoring Kyuubi - Logging System
-Kyuubi uses [Apache Log4j](https://logging.apache.org/) for logging.
Review Comment:
XD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on code in PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#discussion_r944284694
##########
docs/monitor/logging.md:
##########
@@ -105,20 +105,28 @@ Starting org.apache.kyuubi.server.KyuubiServer, logging to /Users/kentyao/tmp/ky
`KYUUBI_MAX_LOG_FILES` controls how many log files will be remained after a Kyuubi server reboots.
-#### Custom Log4j Settings
+#### Custom Log4j2 Settings
-Taking control of `$KYUUBI_HOME/conf/log4j.properties` will also give us the ability of customizing server logging as we want.
+Taking control of `$KYUUBI_HOME/conf/log4j2.xml` will also give us the ability of customizing server logging as we want.
For example, we can disable the console appender and enable the file appender like,
-```properties
-log4j.rootCategory=INFO, FA
-log4j.appender.FA=org.apache.log4j.FileAppender
-log4j.appender.FA.append=false
-log4j.appender.FA.file=log/dummy.log
-log4j.appender.FA.layout=org.apache.log4j.PatternLayout
-log4j.appender.FA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %t %p %c{2}: %m%n
-log4j.appender.FA.Threshold=DEBUG
+```xml
+<Configuration status="INFO">
Review Comment:
The previous documentation described custom output to a file, so this example is retained here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#discussion_r944372304
##########
docs/monitor/logging.md:
##########
@@ -18,7 +18,7 @@
# Monitoring Kyuubi - Logging System
-Kyuubi uses [Apache Log4j](https://logging.apache.org/) for logging.
Review Comment:
hmm... do I have to give you the whole sentence to copy?
Kyuubi uses [Apache Log4j2](https://logging.apache.org/) for logging since version xxx. For versions xxx' and below, it uses [Apache Log4j](https://logging.apache.org/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#issuecomment-1213025164
> Apache Log4j provides a migration guide, we can add the link to doc. https://logging.apache.org/log4j/2.x/manual/migration.html
I suggest we have our own guide to mention log4j's, we may have some other API change now and in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#issuecomment-1212908654
![Uploading WX20220812-172237@2x.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#discussion_r944368533
##########
docs/monitor/logging.md:
##########
@@ -18,7 +18,7 @@
# Monitoring Kyuubi - Logging System
-Kyuubi uses [Apache Log4j](https://logging.apache.org/) for logging.
+Kyuubi uses [Apache Log4j2](https://logging.apache.org/log4j/2.x/) since v1.6.0, for logging.
Review Comment:
v1.6.0 => v1.5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#issuecomment-1215000558
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#issuecomment-1213005957
Apache Log4j provides a migration guide, we can add the link to doc.
https://logging.apache.org/log4j/2.x/manual/migration.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
URL: https://github.com/apache/incubator-kyuubi/pull/3224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#discussion_r944283674
##########
docs/monitor/logging.md:
##########
@@ -18,7 +18,7 @@
# Monitoring Kyuubi - Logging System
-Kyuubi uses [Apache Log4j](https://logging.apache.org/) for logging.
Review Comment:
Kyuubi uses [Apache Log4j2](https://logging.apache.org/log4j/2.x/) for logging since v1.6.0, for ......
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3224: [KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3224:
URL: https://github.com/apache/incubator-kyuubi/pull/3224#issuecomment-1212915678
do we need a migration guide now? @pan3793 @turboFei @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org