You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/08/20 02:21:37 UTC
[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request
#395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations
jerryshao commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/395#discussion_r315483176
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
##########
@@ -43,17 +41,15 @@
private static final String METADATA_FOLDER_NAME = "metadata";
private static final String DATA_FOLDER_NAME = "data";
- private final Configuration conf;
private final FileIO fileIo;
private TableMetadata currentMetadata = null;
private String currentMetadataLocation = null;
private boolean shouldRefresh = true;
private int version = -1;
- protected BaseMetastoreTableOperations(Configuration conf) {
- this.conf = conf;
- this.fileIo = new HadoopFileIO(conf);
+ protected BaseMetastoreTableOperations(FileIO fileIo) {
Review comment:
OK, let me update the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org