[GitHub] ctubbsii commented on a change in pull request #345: ACCUMULO-4769 Sanity check for valid CryptoModule and KeyEncryptionStrategy in config

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #345: ACCUMULO-4769 Sanity check for valid CryptoModule and KeyEncryptionStrategy in config
URL: https://github.com/apache/accumulo/pull/345#discussion_r158140834
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/security/crypto/CryptoModuleFactory.java
 ##########
 @@ -96,23 +95,17 @@ private static CryptoModule instantiateCryptoModule(String cryptoModuleClassname
     }
 
     if (!implementsCryptoModule) {
-      log.warn("Configured Accumulo crypto module \"{}\" does not implement the CryptoModule interface. No encryption will be used.", cryptoModuleClassname);
-      return new NullCryptoModule();
+      throw new RuntimeException("Configured Accumulo crypto module " + cryptoModuleClassname + " does not implement the CryptoModule interface.");
 
 Review comment:
   I wonder if there's a more specific runtime exception which would be more appropriate. IllegalArgumentException? Maybe a custom one? I don't like using RuntimeException directly, instead of through a subclass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services